Skip to content

Commit 2ba0eda

Browse files
committed
Revert sparkline to 1.6
- according to mleibman/SlickGrid#855 sparkline 2+ uses a different allocation model that requires jQuery cleanup - this will have the effect of leaking memory - revert sparkline to 1.6, the last pre-2.0 version - add jquery-migrate to make it work - TODO: create an async post-remove-from-cache cleanup
1 parent ea4f850 commit 2ba0eda

File tree

3 files changed

+98
-4
lines changed

3 files changed

+98
-4
lines changed

examples/example10-async-post-render.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ <h2>Demonstrates:</h2>
5050
The grid is editable, so you can edit the numbers and see the changes reflected (almost) immediately in the graph.
5151
The graph cell behaves just like an ordinary cell and can be resized/reordered.
5252
The graphs themselves are created using the excellent <a href="http://www.omnipotent.net/jquery.sparkline/"
53-
target="_blank">jQuery Sparklines</a> library.
53+
target="_blank">jQuery Sparklines</a> library.<br/><br/>
54+
nb: sparkline 2.x will <a href="https://github.com/mleibman/SlickGrid/issues/855">cause a memory leak</a> in the current architecture, so we use sparkline 1.x and jquery-migrate for now.
5455
</p>
5556
<h2>View Source:</h2>
5657
<ul>
@@ -62,7 +63,9 @@ <h2>View Source:</h2>
6263

6364
<script src="../lib/jquery-1.11.2.min.js"></script>
6465
<script src="../lib/jquery-ui-1.11.3.min.js"></script>
66+
<script src="../lib/jquery-migrate-1.2.1.min.js"></script>
6567
<script src="../lib/jquery.event.drag-2.2.js"></script>
68+
<!-- nb: sparkline 2.x will cause a memory leak in the current architecture, so we use sparkline 1.x and jquery-migrate -->
6669
<script src="../lib/jquery.sparkline.min.js"></script>
6770

6871
<script src="../slick.core.js"></script>

lib/jquery-migrate-1.2.1.min.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)