Live URL fix for checkout/terminal (#140) (#141)

* add fix for bad live url checkout

* removed the terminal part as the base url already contains everything

* Update spec/checkout_spec.rb



---------

Co-authored-by: Colin Rood <[email protected]>
Co-authored-by: Rajni Kewlani <[email protected]>
Co-authored-by: Alexandros Moraitis <[email protected]>
Co-authored-by: Attila Kiss <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>
Co-authored-by: Wouter Boereboom <[email protected]>

Author: 7 people

lib/adyen/client.rb

@@ -83,7 +83,11 @@ def service_url_base(service)
 
     # construct full URL from service and endpoint
     def service_url(service, action, version)
-      "#{service_url_base(service)}/v#{version}/#{action}"
+      if service == "Checkout" && @env == :live
+        return "#{service_url_base(service)}/checkout/v#{version}/#{action}"
+      else
+        return "#{service_url_base(service)}/v#{version}/#{action}"
+      end
     end
 
     # send request to adyen API

spec/checkout_spec.rb

@@ -632,6 +632,23 @@
     ).to have_been_made.once
   end
 
+  # must be created manually because every field in the response is an array
+  it "makes a LIVE paymentMethods call" do
+    request_body = JSON.parse(json_from_file("mocks/requests/Checkout/payment_methods.json"))
+
+    response_body = json_from_file("mocks/responses/Checkout/payment_methods.json")
+
+    adyen = Adyen::Client.new
+    adyen.api_key = 'AF5XXXXXXXXXXXXXXXXXXXX'
+    adyen.env = :live
+    adyen.live_url_prefix = "prefix"
+    url = adyen.service_url("Checkout", "paymentMethods", @shared_values[:client].checkout.version)
+
+    expect(url).
+      to eq("https://prefix-checkout-live.adyenpayments.com/checkout/v70/paymentMethods")
+
+  end
+
 end
 
 # rubocop:enable Metrics/BlockLength

spec/client_spec.rb

@@ -133,7 +133,7 @@
   it "checks the creation of checkout url" do 
     client = Adyen::Client.new(api_key: "api_key", env: :live, live_url_prefix: "YourLiveUrlPrefix")
     expect(client.service_url("Checkout", "paymentMethods", "70")).
-    to eq("https://YourLiveUrlPrefix-checkout-live.adyenpayments.com/v70/paymentMethods")
+    to eq("https://YourLiveUrlPrefix-checkout-live.adyenpayments.com/checkout/v70/paymentMethods")
   end 
   it "checks the creation of lem url" do 
     client = Adyen::Client.new(api_key: "api_key", env: :live)