Code generation: update services and models #329
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of services and models based on recent modifications to OpenAPI specification files. It primarily introduces new capabilities for Strong Customer Authentication (SCA) within the Balance Platform by adding dedicated API clients for managing SCA associations and devices. These changes enhance the platform's security features by providing programmatic control over authentication processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new services, SCAAssociationManagementApi and SCADeviceManagementApi, through code generation. The changes are well-contained and correctly integrated. My review focuses on the generated code in the new files, where I've identified some opportunities for improvement. Specifically, the endpoint URL construction can be simplified to be more idiomatic and readable in Ruby. I've also noted a minor style issue with trailing whitespace. Addressing these points could help refine the code generation templates for future updates.
| endpoint = '/scaAssociations'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) |
There was a problem hiding this comment.
The construction of the endpoint string is overly complex for a static path. It can be simplified to a single string assignment, which improves readability and is more idiomatic in Ruby. This simplification can be applied to the other methods in this file (list_associations on lines 27-29 and remove_association on lines 37-39) as well.
endpoint = 'scaAssociations'| endpoint = '/scaAssociations'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) | ||
|
|
There was a problem hiding this comment.
This line contains trailing whitespace. It's a good practice to remove it to maintain a clean codebase. This issue is also present on line 40 in this file, and on lines 20, 30, and 40 in lib/adyen/services/balancePlatform/sca_device_management_api.rb.
| endpoint = '/scaDevices'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) |
There was a problem hiding this comment.
The construction of the endpoint string for this static path is overly complex. It can be simplified to a single string assignment for better readability and more idiomatic code.
endpoint = 'scaDevices'| endpoint = '/scaDevices/{deviceId}'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint, device_id) |
There was a problem hiding this comment.
This endpoint construction with a path parameter can be made more readable and idiomatic by using Ruby's string interpolation instead of gsub and format. This simplification can also be applied to the submit_sca_association method on lines 37-39.
endpoint = "scaDevices/#{device_id}"
OpenAPI spec files or templates have been modified on 25-11-2025 by commit.