switch to NodeNext module resolution (#12179)

refs: #9005

## Description
This changes all tsconfig projects to use `moduleResolution: 'NodeNext'`, freeing us of ambients! There are still some globals via `exported.js` that we can burn down later but at least those are explicit.

(The previous moduleResolution, 'bundler', was necessary because of our dependence on ambients. It's the mode that assumes everything will be turned into one giant bundle, so whatever hacks and heuristics the local TSC has to do to get the types to resolve is okay. But we actually do publish separate packages so need more strict type resolution behavior.)

I used the hacky script in #12225 but am not proposing to merge that. We might need to run it again when getting off `exported.js` but we can either run it from the branch or do some more (separate) work to make it trunk-worthy. That script uses the TS language server to iterate over files and do the "auto-import" that VS Code does. By changing the moduleResolution from 'bundler' and running that, necessary types are auto-imported. When there's a duplicate name it doesn't always get the right one so some manual fixups were necessary. After doing this for every module in the repo, I was able to change the default so they all are 'NodeNext' now.

### Security Considerations
none

### Scaling Considerations
none

### Documentation Considerations

Any downstream relying on the `types-ambient.js` exports will fail. The solution is just to import explicitly. I think that's a fine change to impose.

### Testing Considerations
CI

Nothing downstream will fail until it updates to a newer release and the fix for any ambients will be trivial.

### Upgrade Considerations
does not affect chain

Author: mergify[bot]

multichain-testing/scripts/ymax-tool.ts

@@ -47,7 +47,7 @@ import {
 import { YieldProtocol } from '@agoric/portfolio-api/src/constants.js';
 import type { OfferStatus } from '@agoric/smart-wallet/src/offers.js';
 import type { NameHub } from '@agoric/vats';
-import type { StartedInstanceKit as ZStarted } from '@agoric/zoe/src/zoeService/utils';
+import type { StartedInstanceKit as ZStarted } from '@agoric/zoe/src/zoeService/utils.js';
 import { SigningStargateClient } from '@cosmjs/stargate';
 import { E } from '@endo/far';
 import { M } from '@endo/patterns';

multichain-testing/tools/batchQuery.js

@@ -38,7 +38,7 @@ async function* mapHistory(f, chunks) {
 }
 
 /**
- * @param {ERef<import('./makeHttpClient').LCD>} lcd
+ * @param {ERef<import('./makeHttpClient.js').LCD>} lcd
  */
 export const makeVStorage = lcd => {
   // height=0 is the same as omitting height and implies the highest block

packages/ERTP/test/swingsetTests/ertpService/ertp-service-upgrade.test.js

@@ -3,6 +3,10 @@ import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';
 import { assert } from '@endo/errors';
 import { buildVatController } from '@agoric/swingset-vat';
 
+/**
+ * @import {SwingSetConfig} from '@agoric/swingset-vat';
+ */
+
 const bfile = name => new URL(name, import.meta.url).pathname;
 
 test('ertp service upgrade', async t => {

packages/ERTP/tsconfig.json

@@ -1,7 +1,8 @@
 // This file can contain .js-specific Typescript compiler config.
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {},
+  "compilerOptions": {
+  },
   "include": [
     // omit exported.js because 1) it need not be included in the typecheck of
     // this package because it's only consumed by other packages and 2)

packages/SwingSet/src/controller/controller.js

@@ -84,8 +84,6 @@ export function computeSha512(bytes) {
  */
 function makeConsole(prefixer) {
   if (typeof prefixer !== 'function') {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore TODO remove when anylogger has types
     const logger = anylogger(prefixer);
     return makeLimitedConsole(level => logger[level]);
   }
@@ -96,8 +94,6 @@ function makeConsole(prefixer) {
       const prefix = prefixer(source);
       let logger = prefixToLogger.get(prefix);
       if (!logger) {
-        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-ignore TODO remove when anylogger has types
         logger = anylogger(prefix);
         prefixToLogger.set(prefix, logger);
       }

packages/SwingSet/src/supervisors/subprocess-node/supervisor-subprocess-node.js

@@ -130,8 +130,6 @@ function handleSetBundle(margs) {
   });
 
   const makeLogMaker = tag => {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore TODO remove when anylogger has types
     const logger = anylogger(tag);
     const makeLog = level => {
       const log = logger[level];

packages/SwingSet/test/util.js

@@ -140,8 +140,6 @@ export function makeRetireImports(...vrefs) {
 }
 
 export const makeConsole = tag => {
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-  // @ts-ignore TODO remove when anylogger has types
   const log = anylogger(tag);
   const cons = /** @type {any} */ (
     Object.fromEntries(logLevels.map(level => [level, log[level]]))

packages/SwingSet/tsconfig.json

@@ -1,12 +1,6 @@
 // This file can contain .js-specific Typescript compiler config.
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {
-    // Default is "esnext" but we need "nodenext" to support ESM in Node.js
-    "module": "nodenext",
-    // Default is "bundler" which is too lax
-    "moduleResolution": "nodenext",
-  },
   "include": [
     "exported.js",
     "demo/**/*.js",

packages/agoric-cli/src/anylogger-agoric.js

@@ -28,6 +28,7 @@ const selectedCode = anylogger.levels[selectedLevel];
 const globalCode = selectedCode === undefined ? -Infinity : selectedCode;
 
 const oldExt = anylogger.ext;
+/** @type {typeof anylogger.ext} */
 anylogger.ext = (l, ...rest) => {
   l = oldExt(l, ...rest);
   l.enabledFor = lvl => globalCode >= anylogger.levels[lvl];

packages/agoric-cli/tools/resm-plugin/deploy.js

@@ -3,6 +3,7 @@ import { E } from '@endo/eventual-send';
 
 const PONG_TIMEOUT = 10_000;
 
+// @ts-expect-error TS1287: A top-level 'export' modifier cannot be used on value declarations in a CommonJS module when 'verbatimModuleSyntax' is enabled.
 export default async function deployPlugin(
   homePromise,
   { installUnsafePlugin },