perf(backend_filesystem): Use comprehensions where to improve performance

Author: amilcarlucas

ardupilot_methodic_configurator/backend_filesystem.py

@@ -599,7 +599,9 @@ def remove_created_files_and_vehicle_dir(self) -> str:
 
             # delete all files in the vehicle directory and delete the vehicle directory
             errors: list[str] = []
-            for item_path in vehicle_path.iterdir():
+
+            def safe_remove_item(item_path: Path) -> Optional[str]:
+                """Safely remove a file or directory, returning error message if failed."""
                 try:
                     # If the entry is a symlink, remove the link instead of recursing into the target
                     if item_path.is_symlink():
@@ -608,9 +610,16 @@ def remove_created_files_and_vehicle_dir(self) -> str:
                         shutil_rmtree(str(item_path))
                     else:
                         item_path.unlink()
+                    return None
                 except OSError as e:
                     logging_exception(_("Error removing %s"), item_path, e)
-                    errors.append(str(e))
+                    return str(e)
+
+            # Remove all items and collect errors
+            for item_path in vehicle_path.iterdir():
+                error = safe_remove_item(item_path)
+                if error:
+                    errors.append(error)
 
             # Try to remove the now-empty vehicle directory
             try: