Fixing Unit tests and linting issues

satyadevai · satyadevai · commit 30aeab79d7c6 · 2025-11-11T23:11:19.000+05:30
diff --git a/js/packages/openinference-instrumentation-anthropic/test/instrumentation.test.ts b/js/packages/openinference-instrumentation-anthropic/test/instrumentation.test.ts
@@ -16,7 +16,7 @@ describe("AnthropicInstrumentation", () => {
   beforeEach(() => {
     exporter = new InMemorySpanExporter();
     provider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(exporter)]
+      spanProcessors: [new SimpleSpanProcessor(exporter)],
     });
     instrumentation = new AnthropicInstrumentation({
       tracerProvider: provider,
diff --git a/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/custom-provider.test.ts b/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/custom-provider.test.ts
@@ -27,7 +27,7 @@ describe("BedrockAgentInstrumentation with a custom tracer provider", () => {
   describe("BedrockAgentInstrumentation with custom TracerProvider passed in", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
     // Instantiate instrumentation with the custom provider
     const instrumentation = new BedrockAgentInstrumentation({
@@ -92,12 +92,11 @@ describe("BedrockAgentInstrumentation with a custom tracer provider", () => {
   });
 
   describe("BedrockkAgentInstrumentation with custom TracerProvider set", () => {
-    
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter),]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
-    
+
     // Instantiate instrumentation with the custom provider
     const instrumentation = new BedrockAgentInstrumentation({});
     instrumentation.setTracerProvider(customTracerProvider);
diff --git a/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.agent-traces.test.ts b/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.agent-traces.test.ts
@@ -37,7 +37,9 @@ describe("BedrockAgentInstrumentation Trace Collector Integration - agent attrib
     instrumentation = new BedrockAgentInstrumentation();
     instrumentation.disable();
     memoryExporter = new InMemorySpanExporter();
-    provider = new NodeTracerProvider({spanProcessors: [new SimpleSpanProcessor(memoryExporter)]});
+    provider = new NodeTracerProvider({
+      spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+    });
     provider.register();
     instrumentation.setTracerProvider(provider);
     // Manually set module exports for testing (following OpenAI pattern)
diff --git a/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.agent-without-traces.test.ts b/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.agent-without-traces.test.ts
@@ -32,7 +32,9 @@ describe("BedrockAgentInstrumentation Integration - agent attributes and API rec
     instrumentation = new BedrockAgentInstrumentation();
     instrumentation.disable();
     memoryExporter = new InMemorySpanExporter();
-    provider = new NodeTracerProvider({spanProcessors: [new SimpleSpanProcessor(memoryExporter)]});
+    provider = new NodeTracerProvider({
+      spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+    });
     provider.register();
     instrumentation.setTracerProvider(provider);
     // Manually set module exports for testing (following OpenAI pattern)
diff --git a/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.rag.test.ts b/js/packages/openinference-instrumentation-bedrock-agent-runtime/test/integration.instrumentation.rag.test.ts
@@ -39,7 +39,9 @@ describe("BedrockAgent RAG Instrumentation - attributes and API recording", () =
     instrumentation = new BedrockAgentInstrumentation();
     instrumentation.disable();
     memoryExporter = new InMemorySpanExporter();
-    provider = new NodeTracerProvider({spanProcessors: [new SimpleSpanProcessor(memoryExporter)]});
+    provider = new NodeTracerProvider({
+      spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+    });
     provider.register();
     instrumentation.setTracerProvider(provider);
     // Manually set module exports for testing (following OpenAI pattern)
diff --git a/js/packages/openinference-instrumentation-bedrock/scripts/validate-converse-comprehensive.ts b/js/packages/openinference-instrumentation-bedrock/scripts/validate-converse-comprehensive.ts
@@ -134,7 +134,9 @@ class ConverseComprehensiveValidator {
       resource: new Resource({
         [SEMRESATTRS_PROJECT_NAME]: "bedrock-converse-comprehensive-validation",
       }),
-      spanProcessors: exporters.map((exporter) => new SimpleSpanProcessor(exporter)),
+      spanProcessors: exporters.map(
+        (exporter) => new SimpleSpanProcessor(exporter),
+      ),
     });
 
     this.provider.register();
diff --git a/js/packages/openinference-instrumentation-bedrock/scripts/validate-converse-stream.ts b/js/packages/openinference-instrumentation-bedrock/scripts/validate-converse-stream.ts
@@ -102,7 +102,6 @@ class ConverseStreamPhoenixValidator {
   }
 
   private setupTracing() {
-    
     // Setup exporters
     const exporters: SpanExporter[] = [new ConsoleSpanExporter()];
 
@@ -140,7 +139,9 @@ class ConverseStreamPhoenixValidator {
         [SEMRESATTRS_PROJECT_NAME]:
           "bedrock-converse-stream-phoenix-validation",
       }),
-      spanProcessors: exporters.map((exporter) => new SimpleSpanProcessor(exporter)),
+      spanProcessors: exporters.map(
+        (exporter) => new SimpleSpanProcessor(exporter),
+      ),
     });
 
     this.provider.register();
diff --git a/js/packages/openinference-instrumentation-bedrock/scripts/validate-invoke-model.ts b/js/packages/openinference-instrumentation-bedrock/scripts/validate-invoke-model.ts
@@ -134,7 +134,9 @@ class InstrumentationValidator {
       resource: new Resource({
         [SEMRESATTRS_PROJECT_NAME]: "bedrock-validation-script",
       }),
-      spanProcessors: exporters.map((exporter) => new SimpleSpanProcessor(exporter)),
+      spanProcessors: exporters.map(
+        (exporter) => new SimpleSpanProcessor(exporter),
+      ),
     });
     this.provider.register();
   }
diff --git a/js/packages/openinference-instrumentation-bedrock/test/instrumentation.test.ts b/js/packages/openinference-instrumentation-bedrock/test/instrumentation.test.ts
@@ -72,7 +72,7 @@ describe("BedrockInstrumentation", () => {
     instrumentation.disable(); // Initially disabled
     spanExporter = new InMemorySpanExporter();
     provider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(spanExporter)]
+      spanProcessors: [new SimpleSpanProcessor(spanExporter)],
     });
 
     provider.register();
@@ -3852,7 +3852,7 @@ describe("BedrockInstrumentation - custom tracing", () => {
     // Setup global tracer provider and span exporter for comparison
     spanExporter = new InMemorySpanExporter();
     provider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(spanExporter)]
+      spanProcessors: [new SimpleSpanProcessor(spanExporter)],
     });
     provider.register();
   });
@@ -4044,7 +4044,7 @@ describe("BedrockInstrumentation - custom tracing", () => {
   describe("BedrockInstrumentation with custom TracerProvider set via registerInstrumentations", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
     let instrumentation: BedrockInstrumentation;
 
diff --git a/js/packages/openinference-instrumentation-langchain/test/langchainV2.test.ts b/js/packages/openinference-instrumentation-langchain/test/langchainV2.test.ts
@@ -166,7 +166,7 @@ const expectedSpanAttributes = {
 
 describe("LangChainInstrumentation", () => {
   const tracerProvider = new NodeTracerProvider({
-    spanProcessors: [new SimpleSpanProcessor(memoryExporter)]
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new LangChainInstrumentation();
@@ -687,7 +687,7 @@ describe("LangChainInstrumentation", () => {
 
 describe("LangChainInstrumentation with TraceConfigOptions", () => {
   const tracerProvider = new NodeTracerProvider({
-        spanProcessors: [new SimpleSpanProcessor(memoryExporter)]
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new LangChainInstrumentation({
@@ -767,7 +767,7 @@ describe("LangChainInstrumentation with a custom tracer provider", () => {
   describe("LangChainInstrumentation with custom TracerProvider passed in", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter),]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
 
     // Instantiate instrumentation with the custom provider
diff --git a/js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts b/js/packages/openinference-instrumentation-langchain/test/langchainV3.test.ts
@@ -838,10 +838,9 @@ describe("LangChainInstrumentation with a custom tracer provider", () => {
   });
 
   describe("LangChainInstrumentation with custom TracerProvider set", () => {
-    
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter),]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
 
     // Instantiate instrumentation with the custom provider
@@ -888,7 +887,7 @@ describe("LangChainInstrumentation with a custom tracer provider", () => {
   describe("LangChainInstrumentation with custom TracerProvider set via registerInstrumentations", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter),]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
 
     // Instantiate instrumentation with the custom provider
diff --git a/js/packages/openinference-instrumentation-openai/examples/instrumentation.ts b/js/packages/openinference-instrumentation-openai/examples/instrumentation.ts
@@ -1,3 +1,5 @@
+import { SEMRESATTRS_PROJECT_NAME } from "@arizeai/openinference-semantic-conventions";
+
 import { diag, DiagConsoleLogger, DiagLogLevel } from "@opentelemetry/api";
 import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-proto";
 import { registerInstrumentations } from "@opentelemetry/instrumentation";
@@ -7,8 +9,6 @@ import {
   NodeTracerProvider,
   SimpleSpanProcessor,
 } from "@opentelemetry/sdk-trace-node";
-import { SEMRESATTRS_PROJECT_NAME } from "@arizeai/openinference-semantic-conventions";
-
 
 import { OpenAIInstrumentation } from "../src/index";
 
@@ -25,8 +25,8 @@ const provider = new NodeTracerProvider({
       new OTLPTraceExporter({
         url: "http://localhost:6006/v1/traces",
       }),
-    ),  
-  ]
+    ),
+  ],
 });
 
 registerInstrumentations({
diff --git a/js/packages/openinference-instrumentation-openai/examples/manual-instrumentation.ts b/js/packages/openinference-instrumentation-openai/examples/manual-instrumentation.ts
@@ -3,15 +3,15 @@
  * This file shows an example of how if openai is already imported, you can manually instrument it after it's been imported.
  */
 
+import { SEMRESATTRS_PROJECT_NAME } from "@arizeai/openinference-semantic-conventions";
+
 import { diag, DiagConsoleLogger, DiagLogLevel } from "@opentelemetry/api";
 import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-proto";
 import { Resource } from "@opentelemetry/resources";
 import {
   NodeTracerProvider,
   SimpleSpanProcessor,
 } from "@opentelemetry/sdk-trace-node";
-import { SEMRESATTRS_PROJECT_NAME } from "@arizeai/openinference-semantic-conventions";
-
 
 import { isPatched, OpenAIInstrumentation } from "../src";
 
diff --git a/js/packages/openinference-instrumentation-openai/test/openai.responses.test.ts b/js/packages/openinference-instrumentation-openai/test/openai.responses.test.ts
@@ -18,7 +18,7 @@ const memoryExporter = new InMemorySpanExporter();
 // Add new describe block for OpenAI Responses tests
 describe("OpenAIInstrumentation - Responses", () => {
   const tracerProvider = new NodeTracerProvider({
-    spanProcessors: [new SimpleSpanProcessor(memoryExporter)] 
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new OpenAIInstrumentation();
diff --git a/js/packages/openinference-instrumentation-openai/test/openai.test.ts b/js/packages/openinference-instrumentation-openai/test/openai.test.ts
@@ -33,7 +33,7 @@ const memoryExporter = new InMemorySpanExporter();
 
 describe("OpenAIInstrumentation", () => {
   const tracerProvider = new NodeTracerProvider({
-    spanProcessors: [new SimpleSpanProcessor(memoryExporter)]
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new OpenAIInstrumentation();
@@ -1110,7 +1110,7 @@ describe("OpenAIInstrumentation", () => {
 
 describe("OpenAIInstrumentation with TraceConfig", () => {
   const tracerProvider = new NodeTracerProvider({
-    spanProcessors: [new SimpleSpanProcessor(memoryExporter)]
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new OpenAIInstrumentation({
@@ -1196,7 +1196,7 @@ describe("OpenAIInstrumentation with TraceConfig", () => {
 
 describe("AzureOpenAIInstrumentation", () => {
   const tracerProvider = new NodeTracerProvider({
-    spanProcessors: [new SimpleSpanProcessor(memoryExporter)]
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
   tracerProvider.register();
   const instrumentation = new OpenAIInstrumentation();
@@ -1405,7 +1405,7 @@ describe("OpenAIInstrumentation with a custom tracer provider", () => {
   describe("OpenAIInstrumentation with custom TracerProvider passed in", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)]
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
     });
     let openai: OpenAI;
 
@@ -1490,8 +1490,8 @@ describe("OpenAIInstrumentation with a custom tracer provider", () => {
   describe("OpenAIInstrumentation with custom TracerProvider set", () => {
     const customMemoryExporter = new InMemorySpanExporter();
     const customTracerProvider = new NodeTracerProvider({
-      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)]
-    });    
+      spanProcessors: [new SimpleSpanProcessor(customMemoryExporter)],
+    });
     let openai: OpenAI;
 
     // Instantiate instrumentation with the custom provider
diff --git a/js/packages/openinference-vercel/src/OpenInferenceSpanProcessor.ts b/js/packages/openinference-vercel/src/OpenInferenceSpanProcessor.ts
@@ -27,14 +27,14 @@ import { addOpenInferenceAttributesToSpan, shouldExportSpan } from "./utils";
  *   exporter,
  *   spanFilter: isOpenInferenceSpan,
  * });
- * 
+ *
  * const tracerProvider = new NodeTracerProvider({
  *   resource: resourceFromAttributes({
  *     [SEMRESATTRS_PROJECT_NAME]: "your-project-name",
  *   }),
  *   spanProcessors: [processor], // <-- pass processor here
  * });
- * 
+ *
  * ```
  */
 export class OpenInferenceSimpleSpanProcessor extends SimpleSpanProcessor {
@@ -88,14 +88,14 @@ export class OpenInferenceSimpleSpanProcessor extends SimpleSpanProcessor {
  *   spanFilter: isOpenInferenceSpan,
  *   config: { maxQueueSize: 2048, scheduledDelayMillis: 5000 },
  * });
- * 
+ *
  * const tracerProvider = new NodeTracerProvider({
  *   resource: resourceFromAttributes({
  *     [SEMRESATTRS_PROJECT_NAME]: "your-project-name",
  *   }),
  *   spanProcessors: [processor], // <-- pass processor here
  * });
- * 
+ *
  * ```
  */
 export class OpenInferenceBatchSpanProcessor extends BatchSpanProcessor {
