Skip to content

Conversation

@melina5656
Copy link
Member

@melina5656 melina5656 commented Sep 12, 2025

Worth noting issues:
The x-ms-identifiers must be applied to a property within an array item. In some cases, it was used incorrectly, so we decided to ignore those instances.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Sep 12, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.CostManagement
Swagger Microsoft.CostManagement-CostManagement
Java com.azure.resourcemanager:azure-resourcemanager-costmanagement
JavaScript @azure/arm-costmanagement
Python azure-mgmt-costmanagement
Go sdk/resourcemanager/costmanagement/armcostmanagement

@github-actions github-actions bot added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 12, 2025
@melina5656 melina5656 changed the title [TSP Migration][cost-management] Migrate cost-managementto TypeSpec [TSP Migration][cost-management] Migrate cost-management to TypeSpec Dec 2, 2025
@pshao25 pshao25 added BreakingChange-Python-Sdk-Approved Approved-LintDiff BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. labels Dec 5, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Dec 5, 2025
@pshao25 pshao25 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Dec 5, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 5, 2025
@pshao25 pshao25 merged commit 2190549 into main Dec 5, 2025
92 of 95 checks passed
@pshao25 pshao25 deleted the cost-management-errorresponse-fix branch December 5, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants