From 6e54fbd5488097b036c3ce79f7cca98c49f35a96 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 19:00:18 +0000 Subject: [PATCH 01/15] Passed the package info for apireview and validate package pipeline --- eng/pipelines/templates/jobs/ci.yml | 8 ++++++-- .../templates/stages/archetype-java-release-batch.yml | 4 +++- .../templates/stages/archetype-java-release-patch.yml | 4 +++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml index d25e167b10bf..633498c91e28 100644 --- a/eng/pipelines/templates/jobs/ci.yml +++ b/eng/pipelines/templates/jobs/ci.yml @@ -260,13 +260,17 @@ jobs: - template: /eng/common/pipelines/templates/steps/create-apireview.yml parameters: - Artifacts: ${{parameters.ReleaseArtifacts}} + PackageInfoFiles: + - ${{ each artifact in parameters.ReleaseArtifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml - template: /eng/common/pipelines/templates/steps/validate-all-packages.yml parameters: - Artifacts: ${{ parameters.Artifacts }} + PackageInfoFiles: + - ${{ each artifact in parameters.Artifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - template: /eng/pipelines/templates/steps/post-job-cleanup.yml diff --git a/eng/pipelines/templates/stages/archetype-java-release-batch.yml b/eng/pipelines/templates/stages/archetype-java-release-batch.yml index d87608095663..2d76d4878abb 100644 --- a/eng/pipelines/templates/stages/archetype-java-release-batch.yml +++ b/eng/pipelines/templates/stages/archetype-java-release-batch.yml @@ -271,8 +271,10 @@ stages: - template: /eng/common/pipelines/templates/steps/create-apireview.yml parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.Artifacts }}: + - $(Pipeline.Workspace)/packages-signed/PackageInfo/${{artifact.name}}.json ArtifactPath: $(Pipeline.Workspace)/packages-signed - Artifacts: ${{parameters.Artifacts}} ConfigFileDir: $(Pipeline.Workspace)/packages-signed/PackageInfo MarkPackageAsShipped: true ArtifactName: packages-signed diff --git a/eng/pipelines/templates/stages/archetype-java-release-patch.yml b/eng/pipelines/templates/stages/archetype-java-release-patch.yml index 7e0decaa3fab..9ca73fa9331a 100644 --- a/eng/pipelines/templates/stages/archetype-java-release-patch.yml +++ b/eng/pipelines/templates/stages/archetype-java-release-patch.yml @@ -170,8 +170,10 @@ stages: ArtifactPath: $(Pipeline.Workspace)/packages-signed - template: /eng/common/pipelines/templates/steps/create-apireview.yml parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.Artifacts }}: + - $(Pipeline.Workspace)/packages-signed/PackageInfo/${{artifact.name}}.json ArtifactPath: $(Pipeline.Workspace)/packages-signed - Artifacts: ${{parameters.Artifacts}} ConfigFileDir: $(Pipeline.Workspace)/packages-signed/PackageInfo MarkPackageAsShipped: true ArtifactName: packages-signed From d30b6c3d4bcc99222ef131cfdba904a6e2de69f2 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 21:56:34 +0000 Subject: [PATCH 02/15] Added test pipeline variable to patch release pipeline --- eng/pipelines/patch-release.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/eng/pipelines/patch-release.yml b/eng/pipelines/patch-release.yml index 1cff7999a982..f6963beaf81b 100644 --- a/eng/pipelines/patch-release.yml +++ b/eng/pipelines/patch-release.yml @@ -1,8 +1,14 @@ trigger: none pr: none + +variables: +- name: TestPipeline + value: false + extends: template: /eng/pipelines/templates/stages/archetype-sdk-client-patch.yml parameters: + TestPipeline: $(TestPipeline) artifacts: - name: azure-sdk-template groupId: com.azure From f59a7904c0fc938fc68b1214870de8efdfed888c Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 21:57:22 +0000 Subject: [PATCH 03/15] Fixed JSON conversion error on windows os --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index 6942abd0baa6..c8387b561aff 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ${{ parameters.PackageInfoFiles }} -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index ab75877a02da..9fbc3b6bc3dd 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ${{ parameters.PackageInfoFiles }} workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From bb71ea912030b41044679ef8c912bfbd3024bfbc Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 22:02:38 +0000 Subject: [PATCH 04/15] Used compile time variable format --- eng/pipelines/patch-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/patch-release.yml b/eng/pipelines/patch-release.yml index f6963beaf81b..3cad9dec5cef 100644 --- a/eng/pipelines/patch-release.yml +++ b/eng/pipelines/patch-release.yml @@ -8,7 +8,7 @@ variables: extends: template: /eng/pipelines/templates/stages/archetype-sdk-client-patch.yml parameters: - TestPipeline: $(TestPipeline) + TestPipeline: ${{ variables.TestPipeline }} artifacts: - name: azure-sdk-template groupId: com.azure From 559b223f6d3fe7ae32a733e24b02ae747b143ed9 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 22:10:28 +0000 Subject: [PATCH 05/15] Escaped forward slash in path --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index c8387b561aff..c135c3dea790 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ${{ parameters.PackageInfoFiles }} + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '/') }}' | ConvertFrom-Json -NoEnumerate) -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index 9fbc3b6bc3dd..808801993418 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles ${{ parameters.PackageInfoFiles }} + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '/') }}' | ConvertFrom-Json -NoEnumerate) workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From 47afd3272c19912a52bda1d78dfb3e07407285e5 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 22:27:18 +0000 Subject: [PATCH 06/15] Used parameter instead --- eng/pipelines/patch-release.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/eng/pipelines/patch-release.yml b/eng/pipelines/patch-release.yml index 3cad9dec5cef..a4c54ebc6e8c 100644 --- a/eng/pipelines/patch-release.yml +++ b/eng/pipelines/patch-release.yml @@ -1,14 +1,15 @@ trigger: none pr: none -variables: +parameters: - name: TestPipeline - value: false + type: boolean + default: false extends: template: /eng/pipelines/templates/stages/archetype-sdk-client-patch.yml parameters: - TestPipeline: ${{ variables.TestPipeline }} + TestPipeline: ${{ parameters.TestPipeline }} artifacts: - name: azure-sdk-template groupId: com.azure From 5c70a9e5ba5fc0825b1f6ae5f296422532c79132 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 22:40:06 +0000 Subject: [PATCH 07/15] Escaped forward slash --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index c135c3dea790..8702836c72ff 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '/') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate) -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index 808801993418..9a36c257e51a 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '/') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate) workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From e2c28bc4e6a3882c3fe8b4771c42c16d7d5caff9 Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 23:27:05 +0000 Subject: [PATCH 08/15] replaced the backslash --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index 8702836c72ff..5e736badce79 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '\\') }}' | ConvertFrom-Json -NoEnumerate) -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index 9a36c257e51a..6d030bd37cfe 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '\\') }}' | ConvertFrom-Json -NoEnumerate) workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From 3be018c025600328608e82a9fb4fa26458b123ec Mon Sep 17 00:00:00 2001 From: ray chen Date: Wed, 19 Nov 2025 23:31:11 +0000 Subject: [PATCH 09/15] Updated test pipeline input --- .../templates/stages/archetype-java-release-batch.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/templates/stages/archetype-java-release-batch.yml b/eng/pipelines/templates/stages/archetype-java-release-batch.yml index 2d76d4878abb..44c1a467194d 100644 --- a/eng/pipelines/templates/stages/archetype-java-release-batch.yml +++ b/eng/pipelines/templates/stages/archetype-java-release-batch.yml @@ -127,8 +127,8 @@ stages: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" - ServiceDirectory: "template" + ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' + ServiceDirectory: ${{ parameters.ServiceDirectory }} TestPipeline: ${{ parameters.TestPipeline }} # Do all the verifications for all the artifacts after the sparse-checkout From 2164e7ccaac58190850273281940b06763d966a4 Mon Sep 17 00:00:00 2001 From: ray chen Date: Thu, 20 Nov 2025 01:02:13 +0000 Subject: [PATCH 10/15] Updated yml to use the array object --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index 5e736badce79..288c775aac76 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '\\') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}') -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index 6d030bd37cfe..ae09d268a940 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\', '\\') }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}') workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From 7cef9b655f68a9edef09b19e41e2c1cefcc249bc Mon Sep 17 00:00:00 2001 From: ray chen Date: Thu, 20 Nov 2025 02:21:21 +0000 Subject: [PATCH 11/15] Dynamic loaded the artifact for set test pipeline version template --- eng/pipelines/templates/jobs/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml index 633498c91e28..23ec1bdc12cd 100644 --- a/eng/pipelines/templates/jobs/ci.yml +++ b/eng/pipelines/templates/jobs/ci.yml @@ -148,8 +148,8 @@ jobs: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" - ServiceDirectory: "template" + ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' + ServiceDirectory: ${{ parameters.ServiceDirectory }} TestPipeline: ${{ parameters.TestPipeline }} # The daily dev build variable isn't used for the PullRequests pipeline but is currently used @@ -344,8 +344,8 @@ jobs: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" - ServiceDirectory: "template" + ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' + ServiceDirectory: ${{ parameters.ServiceDirectory }} TestPipeline: ${{ parameters.TestPipeline }} - template: /eng/common/pipelines/templates/steps/verify-links.yml From 765bfa73c0be58897f210ce54c6f69c1379d0975 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Wed, 19 Nov 2025 18:41:40 -0800 Subject: [PATCH 12/15] Apply suggestions from code review --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- eng/common/pipelines/templates/steps/validate-all-packages.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index 288c775aac76..2722d3c9ecc8 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}') + -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} diff --git a/eng/common/pipelines/templates/steps/validate-all-packages.yml b/eng/common/pipelines/templates/steps/validate-all-packages.yml index ae09d268a940..ab75877a02da 100644 --- a/eng/common/pipelines/templates/steps/validate-all-packages.yml +++ b/eng/common/pipelines/templates/steps/validate-all-packages.yml @@ -34,7 +34,7 @@ steps: -BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) ` -PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) ` -IsReleaseBuild $$(SetAsReleaseBuild) ` - -PackageInfoFiles @('${{ join(''',''', parameters.PackageInfoFiles) }}') + -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) workingDirectory: $(Pipeline.Workspace) displayName: Validate packages and update work items continueOnError: true From 0d2dff2b7a55e203f4d310b890302189378c6bf9 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Wed, 19 Nov 2025 18:42:35 -0800 Subject: [PATCH 13/15] Apply suggestions from code review --- eng/common/pipelines/templates/steps/create-apireview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml index 2722d3c9ecc8..6942abd0baa6 100644 --- a/eng/common/pipelines/templates/steps/create-apireview.yml +++ b/eng/common/pipelines/templates/steps/create-apireview.yml @@ -41,7 +41,7 @@ steps: inputs: filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1 arguments: > - -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) + -PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate) -ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) -ArtifactPath '${{parameters.ArtifactPath}}' -ArtifactName ${{ parameters.ArtifactName }} From db878eab575c2194c7eb31fa9671024bfc277a85 Mon Sep 17 00:00:00 2001 From: ray chen Date: Thu, 20 Nov 2025 17:08:41 +0000 Subject: [PATCH 14/15] Added display name for testPipeline parameter --- eng/pipelines/patch-release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/pipelines/patch-release.yml b/eng/pipelines/patch-release.yml index a4c54ebc6e8c..f7c486ea04b0 100644 --- a/eng/pipelines/patch-release.yml +++ b/eng/pipelines/patch-release.yml @@ -3,6 +3,7 @@ pr: none parameters: - name: TestPipeline + displayName: Test Run Without Version Changes type: boolean default: false From ae13f13f4522f914232170af4b583a7c295afd70 Mon Sep 17 00:00:00 2001 From: ray chen Date: Thu, 20 Nov 2025 20:28:13 +0000 Subject: [PATCH 15/15] Reverted change of set-test-pipeline-version template reference --- eng/pipelines/templates/jobs/ci.yml | 8 ++++---- .../templates/stages/archetype-java-release-batch.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml index 23ec1bdc12cd..633498c91e28 100644 --- a/eng/pipelines/templates/jobs/ci.yml +++ b/eng/pipelines/templates/jobs/ci.yml @@ -148,8 +148,8 @@ jobs: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' - ServiceDirectory: ${{ parameters.ServiceDirectory }} + PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" + ServiceDirectory: "template" TestPipeline: ${{ parameters.TestPipeline }} # The daily dev build variable isn't used for the PullRequests pipeline but is currently used @@ -344,8 +344,8 @@ jobs: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' - ServiceDirectory: ${{ parameters.ServiceDirectory }} + PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" + ServiceDirectory: "template" TestPipeline: ${{ parameters.TestPipeline }} - template: /eng/common/pipelines/templates/steps/verify-links.yml diff --git a/eng/pipelines/templates/stages/archetype-java-release-batch.yml b/eng/pipelines/templates/stages/archetype-java-release-batch.yml index 44c1a467194d..2d76d4878abb 100644 --- a/eng/pipelines/templates/stages/archetype-java-release-batch.yml +++ b/eng/pipelines/templates/stages/archetype-java-release-batch.yml @@ -127,8 +127,8 @@ stages: - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml parameters: - ArtifactsJson: '${{ convertToJson(parameters.Artifacts) }}' - ServiceDirectory: ${{ parameters.ServiceDirectory }} + PackageNames: "azure-sdk-template,azure-sdk-template-two,azure-sdk-template-three" + ServiceDirectory: "template" TestPipeline: ${{ parameters.TestPipeline }} # Do all the verifications for all the artifacts after the sparse-checkout