Parties: When a user updates their account information (party), the start and end dates are overwritten.

[EleonoraPetzold]

What is going wrong?

When saving the party, the PartyModel has “null” for start and end date, even though it was previously loaded with the correct values from the party.

Here:

Core/Console/BExIS.Web.Shell/Areas/BAM/Controllers/PartyServiceController.cs

Line 136 in 45e8480

public ActionResult Edit(PartyModel partyModel, Dictionary<string, string> partyCustomAttributeValues)

[sventhiel]

The problem is not inside the controller, but other class/function-calls behind. So, within the controller, there is a call to update the party instance -

Core/Console/BExIS.Web.Shell/Areas/BAM/Controllers/PartyServiceController.cs

Line 156 in 45e8480

party = Helpers.Helper.EditParty(partyModel, partyCustomAttributeValues, null);

Furthermore, within the helper, there is another call to update corresponding party -

Core/Console/BExIS.Web.Shell/Areas/BAM/Helpers/Helper.cs

Line 139 in 45e8480

internal static Party EditParty(PartyModel partyModel, Dictionary<string, string> partyCustomAttributeValues, IList<PartyRelationship> systemPartyRelationships)

. This creates a final call at the manager to make the changes persistent. Within the function of the manager -

Core/Components/DLM/BExIS.Dlm.Services/Party/PartyManager.cs

Line 235 in 45e8480

public PartyX Update(PartyX newParty)

, there are checks for start and end date, BUT it does not set the updated information that comes along with the party object as a parameter. Instead, the system checks only against "null" values.

[sventhiel]

I changed content of Core/Components/DLM/BExIS.Dlm.Services/Party/PartyManager.cs back to the previous state, because the fix from @EleonoraPetzold is complete. The issue was within the web ui form. The start- and enddate was never sent back to the server.

if (party.StartDate == null)
    party.StartDate = DateTime.MinValue;
if (party.EndDate == null || party.EndDate == DateTime.MinValue)
    party.EndDate = DateTime.MaxValue;