Skip to content

Fix Tailwind theme component defects - #75

Open
arnelirobles wants to merge 5 commits into
mainfrom
fix/tailwind-component-defects
Open

arnelirobles wants to merge 5 commits into
mainfrom
fix/tailwind-component-defects

Conversation

@arnelirobles

Copy link
Copy Markdown
Contributor

Fixes the Tailwind theme defects the demo gallery exposed, plus Skeleton lines.

  • Modal under Tailwind runs without Bootstrap JS:
    • hidden when closed, centred over a scrim with a dark variant when open;
    • Escape closes only the topmost of stacked modals, a backdrop click closes it, and the trap holds focus;
    • focus returns to the trigger, body scroll is locked while it is open;
    • getInstance() returns show, hide, toggle and dispose.
      A data-bs-toggle="modal" trigger is not supported under Tailwind (noted in CHANGELOG).
  • Stepper: steps in a row with labels under the circles. Vertical puts the label beside the circle and indents the content to the label column.
  • ProgressBar fill comes from the theme per variant and falls back to primary for an unknown one.
  • Tooltip: bubble on a role="tooltip" popup that shows on hover and focus, with aria-describedby and Escape to dismiss. The imperative Tooltip({element}) is now hover and focus only (noted in CHANGELOG).
  • Input and Select: label above the field. The Input icon centres on the field and the placeholder no longer repeats the label.
  • Skeleton coerces lines, rows and cols to numbers ("3" gave one bar) and caps them at 100.

Bootstrap output: rendered 12 variants of the touched components on main and on this branch. The HTML is byte-identical except Skeleton with lines: '3'.

Proof: 35 new tests in tests/tailwindComponents.test.js, tests/tailwindReview.test.js and tests/skeletonLines.test.js. Each production line was reverted and its test went red. Full suite 944 passed, build passes. Browser checks: icon and input midpoints match with help text; vertical stepper content x equals label x; one Escape closes only the top modal.

…lwind

Modal now hides, centres and closes itself without Bootstrap JS. Stepper, tooltip and label order come from theme parts, progress fill from the background utility.
Stack-aware modal Escape, scroll lock, getInstance, tooltip aria and Escape, skeleton cap, input field wrapper, vertical stepper header, progress fallback to primary.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3fef68a-4bc1-407b-8a82-3847f3ce1fa8
📥 Commits

Reviewing files that changed from the base of the PR and between 6d4261c and dd0f2a0.

📒 Files selected for processing (13)
  • CHANGELOG.md
  • components/Input/Input.js
  • components/Modal/Modal.js
  • components/ProgressBar/ProgressBar.js
  • components/Select/Select.js
  • components/Skeleton/Skeleton.js
  • components/Stepper/Stepper.js
  • components/Tooltip/Tooltip.js
  • tests/fixtures/tailwindOldHexes.json
  • tests/skeletonLines.test.js
  • tests/tailwindComponents.test.js
  • tests/tailwindReview.test.js
  • themes/tailwind/index.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant