Repository navigation
Fix Tailwind theme component defects - #75
Open
arnelirobles wants to merge 5 commits into
Open
arnelirobles wants to merge 5 commits into
arnelirobles wants to merge 5 commits into
Conversation
…lwind Modal now hides, centres and closes itself without Bootstrap JS. Stepper, tooltip and label order come from theme parts, progress fill from the background utility.
Stack-aware modal Escape, scroll lock, getInstance, tooltip aria and Escape, skeleton cap, input field wrapper, vertical stepper header, progress fallback to primary.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Tailwind theme defects the demo gallery exposed, plus Skeleton
lines.getInstance()returns show, hide, toggle and dispose.A
data-bs-toggle="modal"trigger is not supported under Tailwind (noted in CHANGELOG).role="tooltip"popup that shows on hover and focus, witharia-describedbyand Escape to dismiss. The imperativeTooltip({element})is now hover and focus only (noted in CHANGELOG).lines,rowsandcolsto numbers ("3"gave one bar) and caps them at 100.Bootstrap output: rendered 12 variants of the touched components on main and on this branch. The HTML is byte-identical except Skeleton with
lines: '3'.Proof: 35 new tests in
tests/tailwindComponents.test.js,tests/tailwindReview.test.jsandtests/skeletonLines.test.js. Each production line was reverted and its test went red. Full suite 944 passed, build passes. Browser checks: icon and input midpoints match with help text; vertical stepper content x equals label x; one Escape closes only the top modal.