Close incorrect quadratic-memory fix for u_sf_mRNA_factors - #445
Closed
TTTPOB wants to merge 2 commits into
Closed
Conversation
Author
|
Closing after correcting the allocation analysis in #444. The expanded Delta is a zero-stride view rather than quadratic physical storage, and event_dim=0 can add a linear log_density allocation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction
This PR is being closed because its memory justification was incorrect. The
(B, 1, B, F)Delta.vis a zero-stride expanded view that shares the original(B, F)mRNAstorage; its logicalnumel()does not represent physical allocation.pyro.deterministic()uses.mask(False), and Pyro'sMaskedDistribution.log_prob()returns an expanded scalar zero without evaluating or materializing the underlying Delta value. The inspected TraceELBO path only consumes the resulting scalarlog_prob_sum.Moreover,
event_dim=0gives the Delta a(B, F)batch shape, which causesDelta.__init__to allocate a real(B, F)log_densitytensor. The proposed change therefore does not eliminate quadratic physical storage and can add a linear allocation.The regression tests correctly identify a change in logical distribution shape, but they do not demonstrate reduced VRAM. No Cell2location code change is justified by the evidence presented here.
Detailed correction and measurements: #444