Remove advice to change a line, and/or file pull request w/ BookwormDB code?

[bmschmidt]

I'm not sure I understand the commands in lines 175-177: it looks like this is correcting a bug in the Bookworm code, but I can't tell what it is. If there is one, we should correct it directly rather than force a workaround.

echo "    In line 27 of federalist/federalist/scripts/makeConfiguration.py, change"
echo
echo "    /.my.cnf  --> os.path.expanduser(\"~/.my.cnf\")"

systemConfigFile.read(), the function called in line 27, reads through a list of config files and keeps the values from the last one that it read; since os.path.expanduser("~/.my.cnf") is already in the list after /.my.cnf, the change suggested shouldn't make any difference. Does it?

[theaidenlab]

Right, this bug was fixed a while back.
I forgot to remove it from the install script.

​Thanks!​

• Muhammad Saad Shamim http://mshamim.com/

On Wed, Jun 17, 2015 at 3:39 PM, Benjamin Schmidt notifications@github.com
wrote:

I'm not sure I understand the commands in lines 175-177
https://github.com/Bookworm-project/FreshInstallationScript/blob/master/ubuntu_install_before_bookworm.sh#L175-L177:
it looks like this is correcting a bug in the Bookworm code, but I can't
tell what it is. If there is one, we should correct it directly rather than
force a workaround.

echo " In line 27 of federalist/federalist/scripts/makeConfiguration.py, change"echoecho " /.my.cnf --> os.path.expanduser("~/.my.cnf")"

systemConfigFile.read(), the function called in line 27, reads through a
list of config files and keeps the values from the last one that it read;
since os.path.expanduser("~/.my.cnf") is already in the list after
/.my.cnf, the change suggested shouldn't make any difference. Does it?

—
Reply to this email directly or view it on GitHub
#1.