feat: Enhance vis.py show routine (#1855)

* feat: Enhance vis.py show routine

 - Add parameters azimuth viewup and clipping_range to allow for
   improved control of the rendering.
 - Always call ResetCamera early so the camera is in a known
   state before applying user defined parameters, some of which
   are relative.

* test: Add testing of viewup and clipping_range

* Fix the issue with not updated view

Reset camera orientation if no explicit position is provided.

* Use original logic

---------

Co-authored-by: AU <[email protected]>

Author: winksaville

cadquery/vis.py

@@ -398,8 +398,11 @@ def show(
     zoom: float = 1.0,
     roll: float = -35,
     elevation: float = -45,
+    azimuth: float = 0,
     position: Optional[Tuple[float, float, float]] = None,
     focus: Optional[Tuple[float, float, float]] = None,
+    viewup: Optional[Tuple[float, float, float]] = None,
+    clipping_range: Optional[Tuple[float, float]] = None,
     width: Union[int, float] = 0.5,
     height: Union[int, float] = 0.5,
     trihedron: bool = True,
@@ -503,17 +506,29 @@ def show(
 
     # set camera
     camera = renderer.GetActiveCamera()
+
+    # Update camera position with user provided absolute positions
+    if viewup:
+        camera.SetViewUp(*viewup)
+
+    if focus:
+        camera.SetFocalPoint(*focus)
+
+    if position:
+        camera.SetPosition(*position)
+
+    if not (position or focus):
+        renderer.ResetCamera()  # fit all if no explicit position provided
+
+    # Update camera position with user defined relative positions
     camera.Roll(roll)
     camera.Elevation(elevation)
-    camera.Zoom(zoom)
+    camera.Azimuth(azimuth)
 
-    if position or focus:
-        if position:
-            camera.SetPosition(*position)
-        if focus:
-            camera.SetFocalPoint(*focus)
-    else:
-        renderer.ResetCamera()
+    # Update camera view frustum
+    camera.Zoom(zoom)
+    if clipping_range:
+        camera.SetClippingRange(*clipping_range)
 
     # initialize and set size
     inter.Initialize()

tests/test_vis.py

@@ -222,3 +222,14 @@ def test_camera_position(wp, patch_vtk):
     show(wp, position=(0, 0, 1), focus=(0, 0.1, 0))
     show(wp, focus=(0, 0.1, 0))
     show(wp, position=(0, 0, 1))
+
+    # Specify Z up
+    show(wp, viewup=(0, 0, 1), position=(0, -1, 0), focus=(0, 0.1, 0))
+    show(wp, focus=(0, 0.1, 0))
+    show(wp, position=(0, -1, 0))
+    show(wp, viewup=(0, 0, 1))
+
+
+def test_frustrum_clipping_range(wp, patch_vtk):
+
+    show(wp, zoom=2.0, clipping_range=(1, 100))