For #4700 part about incMayPlayTurn
I want Player::getLandPlayedThisTurn to return a List<SpellAbility> (mostly LandAbility)
maybe stored in Game like SpellCastThisTurn (but Lands can only be played by active turn player?)
|
public final int getLandsPlayedThisTurn() { |
|
return landsPlayedThisTurn; |
|
} |
|
public final int getLandsPlayedLastTurn() { |
|
return landsPlayedLastTurn; |
|
} |
|
public final void addLandPlayedThisTurn() { |
|
landsPlayedThisTurn++; |
|
achievementTracker.landsPlayed++; |
|
view.updateNumLandThisTurn(this); |
|
} |
While checking this code, I found this problem:
|
boolean oppSkippedLandDrop = (tgtPlayer.getLandsPlayedLastTurn() == 0 && ph.isPlayerTurn(ai)) |
|
|| (tgtPlayer.getLandsPlayedThisTurn() == 0 && ph.isPlayerTurn(tgtPlayer) && ph.getPhase().isAfter(PhaseType.MAIN2)); |
LandsPlayedLastTurn isn't really correct for multiplayer, because it doesn't look at TargetPlayers last turn.
If I store a copy of the LandAbility, I might implement this in java:
|
T:Mode$ LandPlayed | Origin$ Exile | ValidCard$ Land.YouCtrl | Execute$ StoreVar | Static$ True |
|
SVar:StoreVar:DB$ StoreSVar | SVar$ LandsPlayedFromExile | Type$ Number | Expression$ 1 |
|
T:Mode$ LandPlayed | Origin$ Exile,Library,Graveyard | ValidCard$ Land.YouCtrl | Execute$ StoreVar | Static$ True |
|
SVar:StoreVar:DB$ StoreSVar | SVar$ LandsPlayedFromNotHand | Type$ Number | Expression$ 1 |
For #4700 part about
incMayPlayTurnI want Player::getLandPlayedThisTurn to return a
List<SpellAbility>(mostly LandAbility)maybe stored in Game like
SpellCastThisTurn(but Lands can only be played by active turn player?)forge/forge-game/src/main/java/forge/game/player/Player.java
Lines 2245 to 2255 in 226cc45
While checking this code, I found this problem:
forge/forge-ai/src/main/java/forge/ai/ability/DestroyAi.java
Lines 418 to 419 in 226cc45
LandsPlayedLastTurn isn't really correct for multiplayer, because it doesn't look at TargetPlayers last turn.
If I store a copy of the LandAbility, I might implement this in java:
forge/forge-gui/res/cardsfolder/v/visions_of_phyrexia.txt
Lines 11 to 12 in a81bd0f
forge/forge-gui/res/cardsfolder/s/spider_man_2099.txt
Lines 13 to 14 in a81bd0f