Improve CubicPlayerManager and add support for third party modded cubic world generators by RecursivePineapple · Pull Request #46 · Cardinalstars/CubicChunks1710

RecursivePineapple · 2026-04-12T15:09:05Z

Code changes

Rewrote CubicPlayerManager to fix a lot of its race conditions. There's still a problem with the underworld's mushrooms and boulders not syncing, but I'm not sure what's causing that. Vanilla works fine, so I'm going to ignore it for now 🤣.
Added the ICubicWorldProvider interface, which is used by third party mods to make their dimensions cubic.
Added some (seemingly unused) utilities for this (see CubeStackBlockView).
Removed a large number of allocations (mostly CallbackInfoReturnables) by changing mixins around.
Sorted out cube/chunk ticking. This was a mess before, and there was a lot of unused pointless code.
Accidentally fixed the entity tracking issues by fixing CubicPlayerManager. Previously, entities in new chunks wouldn't be synced properly, causing them to glitch out constantly. Now, everything works normally.

Testing done

Fly around in the vanilla overworld. Whole chunks used to not sync, trees would pop into existence, and there would be this weird gradient pattern on water (see below). Now, everything will sync fine and there won't be skipped block updates.
Also fly around on a server, to make sure everything works the same.
For the memory allocations, I used visualvm and async profiler to diagnose which objects were allocated the most. The asprof -d 30 -f profile.html -e alloc GradleStart command will make a profile that shows allocations, but asprof only works on linux.
Publish CC to the local maven repo and run UtilitiesInExcess with it, to test the cubic underworld world generator.
For ticking, I placed water on a grassy hill and let it sit. The water cascaded properly and the grass below it slowly decayed into dirt.
For animals, I ran around the vanilla overworld and made sure they were working properly. I could bump into them as expected and hit them fine. I also tested mobs in the underworld, since it spawns them frequently.

Weird water gradients

Stress test

https://discord.com/channels/181078474394566657/1415607665375313961/1492890103457255564

DarkShadow44

A bunch of questions and some points that could need improvement. Please don't resolve those, leave that for me.

DarkShadow44 · 2026-05-14T16:51:55Z

+    }
+
+    @ModifyVariable(method = "generate", at = @At("LOAD"), ordinal = 1, argsOnly = true)
+    public int fixHeight(int value, @Local(argsOnly = true) World world, @Local(argsOnly = true, ordinal = 0) int x,


Do we really need to inject that at every load? At least that's what it currently does. TBH, I can't really follow this mixin's logic.

Yeah that's one of its issues. I couldn't figure out how to modify the variable at the head.

DarkShadow44 · 2026-05-14T16:57:14Z


    void updateLightBetween(Chunk column, int localX, int y1, int y2, int localZ);

-    default void onSendCubes(Iterable<? extends ICube> cubes) {


Can't we remove the whole method? It's currently unused.

DarkShadow44 · 2026-05-14T17:06:11Z

            args = "array=get",
            target = "Lnet/minecraft/world/chunk/Chunk;storageArrays:[Lnet/minecraft/world/chunk/storage/ExtendedBlockStorage;"))
    private ExtendedBlockStorage init_getStorage(ExtendedBlockStorage[] ebs, int y) {
-        return ebs[y - (this.isColumn ? 0 : blockToCube(((IMinMaxHeight) worldObj).getMinHeight()))];


Why exactly can we remove that?

The ebs array normally starts at y=0. It seems like modern CC shifts the ebses down as new cubes are added, which is kinda odd because all code that I've seen that interacts with the array expects it to have 16 indices. This is better compat-wise.

Then the entire mixin can be removed, shouldn't do anything anymore right?

DarkShadow44 · 2026-05-14T17:09:43Z

            args = "array=get",
            target = "Lnet/minecraft/world/chunk/Chunk;storageArrays:[Lnet/minecraft/world/chunk/storage/ExtendedBlockStorage;"))
    private ExtendedBlockStorage getBlock_getStorage(ExtendedBlockStorage[] ebs, int y) {
-        return isColumn ? getEBS_CubicChunks(y) : ebs[y];


Why can we remove this?

Everything should route through the same code either way, this is just for simplification from what I can see. I don't remember the specifics, all of these changes were really finicky.

DarkShadow44 · 2026-05-14T22:02:19Z

+     * double-ticking is avoided by checking this lastTicked field instead of deduplication by putting them all into a
+     * Set.
     */
    private long lastTicked = Long.MIN_VALUE;


This is now unused. Is this correct or do we still need to workaround whatever issue this tried to prevent?

DarkShadow44 · 2026-05-14T22:05:42Z

    }

    public static int getLocalAddress(int localX, int localZ) {
-        return (Bits.packUnsignedToInt(localX, 4, 0) | Bits.packUnsignedToInt(localZ, 4, 4));


Shouldn't this also get the & 0xF treatment for consistency?

DarkShadow44 · 2026-05-14T22:06:11Z

-                        cubesToUnload.add(new CubePos(cubeX, cubeY, cubeZ));
-                    }
-                }
+    public WorldVisibilityChange findChanged(CubePos oldPos, CubePos newPos, int oldHorizonalView, int oldVerticalView,


oldHorizonalView -> oldHorizontalView

DarkShadow44 · 2026-05-14T22:06:52Z

    }

    public void registerCallback(CubeLoaderCallback callback) {
-        if (callback != null) this.callbacks.add(callback);


Why drop those checks?

DarkShadow44 · 2026-05-14T23:36:28Z

+                if (columnData.syncedCubeCount <= 0) {
+                    syncedColumns.remove(pos.getX(), pos.getZ());
+
+                    if (player.isWatchingColumn(pos.getX(), pos.getZ())) {


While were at it, can we add

MinecraftForge.EVENT_BUS.post(new ChunkWatchEvent.UnWatch( new ChunkCoordIntPair(pos.getX(), pos.getZ()), player.player));

here? Similar for Watch event. This makes FMP work (at least until you reload the chunk)

RecursivePineapple added 12 commits April 7, 2026 14:57

Third party world generator support + rewrite CubicPlayerManager

59181d1

Sort out chunk + cube ticking

9bbe100

Reduce allocations

6f0e392

Cleanup

29d141c

Update buildscript

5dd87b5

:prayge: it works + cleanup

801f620

Last round of fixes

0759cc0

Sync per player

c8d7a31

Don't reuse player array

15ecac4

oops 😇

d8c4b43

cleanup packet creation

f2cea19

spotless

392ad03

RecursivePineapple mentioned this pull request Apr 12, 2026

WIP Cubic Chunks compat for the Underworld GTNewHorizons/UtilitiesInExcess#129

Draft

RecursivePineapple added 3 commits April 12, 2026 15:06

Fix client height map

6035dc9

Update dependencies.gradle

40730e8

Update CubeProviderServer.java

dff74e2

DarkShadow44 reviewed Apr 14, 2026

View reviewed changes

Comment thread src/main/java/com/cardinalstar/cubicchunks/util/AddressTools.java

DarkShadow44 reviewed May 14, 2026

View reviewed changes


		void updateLightBetween(Chunk column, int localX, int y1, int y2, int localZ);

		default void onSendCubes(Iterable<? extends ICube> cubes) {

Conversation

RecursivePineapple commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code changes

Testing done

See Also

Weird water gradients

Stress test

Uh oh!

Uh oh!

DarkShadow44 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RecursivePineapple commented Apr 12, 2026 •

edited

Loading