Skip to content

Commit a706332

Browse files
committed
Small interface changes in dialable.go
1 parent aa68182 commit a706332

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

internal/mdns/dialable.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ var (
1515
ErrTCPListenAddressNotFound = errors.New("TCP listen address not found")
1616
)
1717

18-
func getMDNSIPsAndPort(p2pHost Networker) (ips []net.IP, port uint16) {
19-
tcpAddresses, err := getDialableListenAddrs(p2pHost)
18+
func getMDNSIPsAndPort(network interfaceListenAddressesGetter) (ips []net.IP, port uint16) {
19+
tcpAddresses, err := getDialableListenAddrs(network)
2020
if err != nil {
2121
const defaultPort = 4001
2222
return nil, defaultPort
@@ -31,8 +31,8 @@ func getMDNSIPsAndPort(p2pHost Networker) (ips []net.IP, port uint16) {
3131
return ips, port
3232
}
3333

34-
func getDialableListenAddrs(p2pHost Networker) (tcpAddresses []*net.TCPAddr, err error) {
35-
multiAddresses, err := p2pHost.Network().InterfaceListenAddresses()
34+
func getDialableListenAddrs(network interfaceListenAddressesGetter) (tcpAddresses []*net.TCPAddr, err error) {
35+
multiAddresses, err := network.InterfaceListenAddresses()
3636
if err != nil {
3737
return nil, fmt.Errorf("listing host interface listen addresses: %w", err)
3838
}

internal/mdns/interfaces.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package mdns
66
import (
77
"github.com/libp2p/go-libp2p-core/network"
88
"github.com/libp2p/go-libp2p-core/peer"
9+
"github.com/multiformats/go-multiaddr"
910
)
1011

1112
// Logger is a logger interface for the mDNS service.
@@ -24,3 +25,8 @@ type IDNetworker interface {
2425
type Networker interface {
2526
Network() network.Network
2627
}
28+
29+
// interfaceListenAddressesGetter returns the listen addresses of the interfaces.
30+
type interfaceListenAddressesGetter interface {
31+
InterfaceListenAddresses() ([]multiaddr.Multiaddr, error)
32+
}

internal/mdns/mdns.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (s *Service) Start() (err error) {
5656
return nil
5757
}
5858

59-
ips, port := getMDNSIPsAndPort(s.p2pHost)
59+
ips, port := getMDNSIPsAndPort(s.p2pHost.Network())
6060

6161
hostID := s.p2pHost.ID()
6262

0 commit comments

Comments
 (0)