NameString argument validation fixes. (#347)

Author: michaelstaib

src/Abstractions/GraphQLNonNullAttribute.cs

@@ -7,7 +7,8 @@ namespace HotChocolate
     public sealed class GraphQLNonNullAttribute
         : Attribute
     {
-        public bool ElementIsNullable { get; set; } = false;
-        public bool IsNullable { get; set; } = false;
+        public bool ElementIsNullable { get; set; }
+
+        public bool IsNullable { get; set; }
     }
 }

src/Core/Execution/ExecutionContext.cs

@@ -172,7 +172,7 @@ private static object ResolveRootValue(
             object initialValue)
         {
             object initVal = initialValue;
-            if (initVal == null && schema.TryGetNativeType(
+            if (initVal == null && schema.TryGetClrType(
                operationType.Name, out Type nativeType))
             {
                 initVal = services.GetService(nativeType);
@@ -185,7 +185,7 @@ private static object CreateRootValue(
             ISchema schema,
             ObjectType operationType)
         {
-            if (schema.TryGetNativeType(
+            if (schema.TryGetClrType(
                 operationType.Name,
                 out Type nativeType))
             {

src/Core/Execution/ExecutionStrategyBase.Resolver.cs

@@ -105,10 +105,10 @@ Task<object> ExecuteResolver()
                 return ExecuteFieldMiddlewareAsync(
                     resolverTask,
                     cancellationToken);
-            };
+            }
         }
 
-        protected void CompleteValue(
+        protected static void CompleteValue(
             FieldValueCompletionContext completionContext)
         {
             _fieldValueCompleter.CompleteValue(completionContext);

src/Core/Execution/ExecutionStrategyBase.cs

@@ -64,7 +64,6 @@ private async Task ExecuteResolverBatchAsync(
         {
             // start field resolvers
             BeginExecuteResolverBatch(
-                executionContext,
                 currentBatch,
                 cancellationToken);
 
@@ -82,7 +81,6 @@ await EndExecuteResolverBatchAsync(
         }
 
         private void BeginExecuteResolverBatch(
-            IExecutionContext executionContext,
             IEnumerable<ResolverTask> currentBatch,
             CancellationToken cancellationToken)
         {

src/Core/Execution/SubscriptionExecutionStrategy.cs

@@ -13,7 +13,7 @@ namespace HotChocolate.Execution
     internal class SubscriptionExecutionStrategy
         : ExecutionStrategyBase
     {
-        public override async Task<IExecutionResult> ExecuteAsync(
+        public override Task<IExecutionResult> ExecuteAsync(
             IExecutionContext executionContext,
             CancellationToken cancellationToken)
         {
@@ -22,10 +22,17 @@ public override async Task<IExecutionResult> ExecuteAsync(
                 throw new ArgumentNullException(nameof(executionContext));
             }
 
-            EventDescription @event = CreateEvent(executionContext);
+            return ExecuteInternalAsync(executionContext, cancellationToken);
+        }
+
+        private async Task<IExecutionResult> ExecuteInternalAsync(
+            IExecutionContext executionContext,
+            CancellationToken cancellationToken)
+        {
+            EventDescription eventDescription = CreateEvent(executionContext);
 
             IEventStream eventStream = await SubscribeAsync(
-                executionContext.Services, @event);
+                executionContext.Services, eventDescription);
 
             return new SubscriptionResult(
                 eventStream,
@@ -36,7 +43,8 @@ public override async Task<IExecutionResult> ExecuteAsync(
                 ExecuteSubscriptionQueryAsync);
         }
 
-        private EventDescription CreateEvent(IExecutionContext executionContext)
+        private EventDescription CreateEvent(
+            IExecutionContext executionContext)
         {
             IReadOnlyCollection<FieldSelection> selections = executionContext
                 .CollectFields(

src/Core/Execution/Utilities/ArgumentResolver.cs

@@ -43,7 +43,7 @@ public Dictionary<string, ArgumentValue> CoerceArgumentValues(
             return coercedArgumentValues;
         }
 
-        private object CoerceArgumentValue(
+        private static object CoerceArgumentValue(
             string argumentName,
             IInputType argumentType,
             IValueNode defaultValue,

src/Core/Execution/Utilities/DictionaryToObjectConverter.cs

@@ -67,7 +67,9 @@ protected override void VisitList(
             }
             else
             {
-                Type elementType = DotNetTypeInfoFactory.GetInnerListType(context.Type);
+                Type elementType = DotNetTypeInfoFactory
+                    .GetInnerListType(context.Type);
+
                 if (elementType != null)
                 {
                     Type listType = typeof(List<>).MakeGenericType(elementType);
@@ -79,8 +81,10 @@ protected override void VisitList(
                         valueContext.Type = context.Type.GetElementType();
                         Visit(list[i], valueContext);
 
-                        list.Add(valueContext.Object);
+                        l.Add(valueContext.Object);
                     }
+
+                    context.Object = l;
                 }
             }
         }

src/Core/Execution/Utilities/DirectiveCollector.cs

@@ -123,7 +123,7 @@ private IEnumerable<IDirective> GetFieldSelectionDirectives(
             }
         }
 
-        private void CollectTypeSystemDirectives(
+        private static void CollectTypeSystemDirectives(
             HashSet<string> processed,
             List<IDirective> directives,
             ObjectField field)

src/Core/Execution/Utilities/FieldCollector.cs

@@ -82,7 +82,7 @@ private void ResolveFields(
             }
         }
 
-        private void ResolveFieldSelection(
+        private static void ResolveFieldSelection(
             ObjectType type,
             FieldNode fieldSelection,
             Action<QueryError> reportError,
@@ -142,7 +142,7 @@ private bool ShouldBeIncluded(ISelectionNode selection)
             return selection.Directives.Include(_variables);
         }
 
-        private bool DoesTypeApply(IType typeCondition, ObjectType current)
+        private static bool DoesTypeApply(IType typeCondition, ObjectType current)
         {
             if (typeCondition is ObjectType ot)
             {

src/Core/Execution/Utilities/QueryResultVisitor.cs

@@ -7,8 +7,12 @@
 
 namespace HotChocolate.Execution
 {
-    internal abstract class QueryResultVisitor<TContext>
+    internal class QueryResultVisitor<TContext>
     {
+        protected QueryResultVisitor()
+        {
+        }
+
         public virtual void Visit(object value, TContext context)
         {
             if (value is IDictionary<string, object> dictionary)
@@ -52,7 +56,6 @@ protected virtual void VisitList(IList<object> list, TContext context)
 
         protected virtual void VisitValue(object value, TContext context)
         {
-
         }
     }
 }