Release Finalization (#326)

Author: michaelstaib

README.md

@@ -8,7 +8,7 @@
 
 _Hot Chocolate_ is a GraphQL server and parser implementation based on the current GraphQL [June 2018 specification](http://facebook.github.io/graphql/June2018/) defined by Facebook.
 
-We are currently in the process of closing some gaps and hope to finalise Version 1 by September. We have listed the implemented specification parts at the bottom of this readme.
+We are currently in the process of closing some gaps and hope to finalise Version 1 by December. We have listed our progress toward version one at the bottom of this readme.
 
 ## Getting Started
 
@@ -186,7 +186,7 @@ cd myserver
 dotnet new graphql-server
 ```
 
-## Features
+## Features and Roadmap
 
 We currently support the following parts of the current [June 2018 specification](http://facebook.github.io/graphql/June2018/) of GraphQL.
 
@@ -290,6 +290,7 @@ We are currently working on the following features that are proposed for the nex
 ## Supported Frameworks
 
 - [ ] ASP.NET Classic
+
   - [ ] _Get_ (in development - 0.7.0)
   - [ ] _Post_ (in development - 0.7.0)
   - [ ] _WebSockets_ (in development - 0.8.0)

src/Core.Tests/CodeFirstTests.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Execution;
 using HotChocolate.Resolvers;
 using HotChocolate.Types;

src/Core.Tests/Core.Tests.csproj

@@ -23,12 +23,13 @@
     <PackageReference Include="Moq" Version="4.8.1" />
     <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="4.5.1" />
     <PackageReference Include="Microsoft.Extensions.DiagnosticAdapter" Version="2.1.0" />
-    <PackageReference Include="ChilliCream.Testing.Utilities" Version="0.1.0" />
+    <PackageReference Include="ChilliCream.Testing.Utilities" Version="0.2.0" />
     <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
   </ItemGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\Core\Core.csproj" />
+    <ProjectReference Include="..\Subscriptions.InMemory\Subscriptions.InMemory.csproj" />
   </ItemGroup>
 
   <ItemGroup>

src/Core.Tests/Execution/ArgumentTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Configuration;
 using HotChocolate.Language;
 using HotChocolate.Types;

src/Core.Tests/Execution/Errors/ErrorTests.cs

@@ -49,5 +49,19 @@ public void FieldError_CreateWithoutLocation()
             Assert.Equal("foo", error.Extensions["fieldName"]);
             Assert.Null(error.Locations);
         }
+
+        [Fact]
+        public void VariableError_CreateWithoutLocation()
+        {
+            // arrange
+            // act
+            var error = new VariableError("foo", "bar");
+
+            // assert
+            Assert.Equal("foo", error.Message);
+            Assert.Equal("bar", error.Extensions["variableName"]);
+            Assert.Null(error.Locations);
+            Assert.Null(error.Path);
+        }
     }
 }

src/Core.Tests/Execution/OperationExecuterErrorTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Types;
 using Xunit;
 

src/Core.Tests/Execution/QueryDirectiveTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Resolvers;
 using HotChocolate.Runtime;
 using HotChocolate.Types;

src/Core.Tests/Execution/QueryExecuterTests.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Language;
 using Xunit;
 

src/Core.Tests/Execution/QueryResultTests.cs

@@ -0,0 +1,105 @@
+using System;
+using HotChocolate.Execution;
+using Xunit;
+
+namespace Core.Tests.Execution
+{
+    public class QueryResultTests
+    {
+        [Fact]
+        public void Create_OnlyData_DataIsReadOnly()
+        {
+            // arrange
+            var data = new OrderedDictionary();
+            Assert.False(data.IsReadOnly);
+
+            // act
+            var result = new QueryResult(data);
+
+            // assert
+            Assert.True(result.Data.IsReadOnly);
+            Assert.True(data.IsReadOnly);
+        }
+
+        [Fact]
+        public void ToJson_OnlyData_JsonStringNoIndentations()
+        {
+            // arrange
+            var data = new OrderedDictionary();
+            var result = new QueryResult(data);
+
+            // act
+            string json = result.ToJson(false);
+
+
+            // assert
+
+        }
+
+        [Fact]
+        public void Create_OnlyData_ErrorIsNull()
+        {
+            // arrange
+            var data = new OrderedDictionary();
+
+            // act
+            var result = new QueryResult(data);
+
+            // assert
+            Assert.Null(result.Errors);
+        }
+
+        [Fact]
+        public void Create_DataIsNull_ArgumentNullException()
+        {
+            // arrange
+            // act
+            Action a = () => new QueryResult((OrderedDictionary)null);
+
+            // assert
+            Assert.Throws<ArgumentNullException>(a);
+        }
+
+        [Fact]
+        public void Create_OnlyError_ErrorIsReadOnly()
+        {
+            // arrange
+            var data = new OrderedDictionary();
+            Assert.False(data.IsReadOnly);
+
+            // act
+            var result = new QueryResult(data);
+
+            // assert
+            Assert.True(result.Data.IsReadOnly);
+            Assert.True(data.IsReadOnly);
+        }
+
+        [Fact]
+        public void Create_WithOneError_ContainsOneError()
+        {
+            // arrange
+            QueryError error = new QueryError("foo");
+
+            // act
+            var result = new QueryResult(error);
+
+            // assert
+            Assert.Collection(result.Errors,
+                t => Assert.Equal(error, t));
+        }
+
+        [Fact]
+        public void Create_OnlyError_DataIsNull()
+        {
+            // arrange
+            QueryError error = new QueryError("foo");
+
+            // act
+            var result = new QueryResult(error);
+
+            // assert
+            Assert.Null(result.Data);
+        }
+    }
+}

src/Core.Tests/Execution/SchemaDirectiveTests.cs

@@ -1,4 +1,5 @@
 using System.Threading.Tasks;
+using ChilliCream.Testing;
 using HotChocolate.Types;
 using Xunit;