Add's Battery for Laptop Users #1137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
requested changes
Oct 6, 2025
Collaborator
adamperkowski
left a comment
adamperkowski
left a comment
There was a problem hiding this comment.
hey guys remember me
Comment on lines
+166
to
+168
| if ls /sys/class/power_supply/ 2>/dev/null | grep -q '^BAT'; then | ||
| sed -i '35s/^\(.\{36\}\)/\1'" battery"'/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini" | ||
| fi |
Collaborator
There was a problem hiding this comment.
Suggested change
| if ls /sys/class/power_supply/ 2>/dev/null | grep -q '^BAT'; then | |
| sed -i '35s/^\(.\{36\}\)/\1'" battery"'/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini" | |
| fi | |
| for p in /sys/class/power_supply/BAT*; do | |
| if [[ -e "$p" ]]; then | |
| sed -i '35s/^\(.\{36\}\)/\1 battery/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini" | |
| fi | |
| done |
idk if that was ur intention but ur implementation would only run on the first file it matches. also shellcheck and also cleaned up this regex mess
Contributor
Author
I thought you died 🤣 |
Collaborator
come on man |
Collaborator
based btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add's Battery for Laptop Users
Testing
None done as no VM (@ChrisTitusTech Test on your laptop)
Impact
HIgh for Laptop Users as it allows them to see there battery percentage
Issues / other PRs related
Additional Information
Checklist