Skip to content

Add's Battery for Laptop Users #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Real-MullaC wants to merge 1 commit into from
Closed

Add's Battery for Laptop Users #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/tabs/applications-setup/dwmtitus-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,13 @@
fi
}


batteryShown() {
if ls /sys/class/power_supply/ 2>/dev/null | grep -q '^BAT'; then

Check warning on line 166 in core/tabs/applications-setup/dwmtitus-setup.sh

View workflow job for this annotation

GitHub Actions / Shellcheck 

[shellcheck] reported by reviewdog 🐶
Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.

Raw Output:
./core/tabs/applications-setup/dwmtitus-setup.sh:166:8: warning: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. (ShellCheck.SC2010)
sed -i '35s/^\(.\{36\}\)/\1'" battery"'/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini"
fi
Comment on lines +166 to +168
Copy link
Collaborator

@adamperkowski adamperkowski Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ls /sys/class/power_supply/ 2>/dev/null | grep -q '^BAT'; then
sed -i '35s/^\(.\{36\}\)/\1'" battery"'/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini"
fi
for p in /sys/class/power_supply/BAT*; do
if [[ -e "$p" ]]; then
sed -i '35s/^\(.\{36\}\)/\1 battery/' "$HOME/.local/dwm-titus/polybar/themes/minimal/config.ini"
fi
done

idk if that was ur intention but ur implementation would only run on the first file it matches. also shellcheck and also cleaned up this regex mess

}

checkEnv
checkEscalationTool
setupDisplayManager
Expand Down
Loading