Addressing IT issues

Author: prabahal

plugins/module_utils/msd/query_child_fab.py

@@ -176,7 +176,10 @@ def commit(self):
         self.results.state = self.rest_send.state
         # pylint: disable=no-member
         self.results.diff_current = add_to_diff
-        self.results.result_current = {"success": True, "found": True}
+        if not add_to_diff:
+            self.results.result_current = {"success": True, "found": False}
+        else:
+            self.results.result_current = {"success": True, "found": True}
         self.results.response_current = copy.deepcopy(
             self.rest_send.response_current
         )

plugins/modules/dcnm_child_fabric.py

@@ -155,7 +155,7 @@ def __init__(self, params):
         msg += f"check_mode: {self.check_mode}"
         self.log.debug(msg)
 
-    def verify_parent_fab_exists_in_controller(self):
+    def verify_msd_fab_exists_in_controller(self):
         method_name = inspect.stack()[0][3]
         for item in self.payloads:
             for fabric in self.data:
@@ -168,7 +168,7 @@ def verify_parent_fab_exists_in_controller(self):
                 msg += "is not found in Controller. Please create and try again"
                 raise ValueError(msg)
 
-    def verify_parent_fab_is_MSD(self):
+    def verify_msd_fab_type(self):
         method_name = inspect.stack()[0][3]
         for item in self.payloads:
             for fabric in self.data:
@@ -226,10 +226,10 @@ def get_want(self):
                 msg += f"value {config}."
                 raise ValueError(msg)
             try:
-                parent_fabric = config.get("FABRIC_NAME", None)
+                msd_fabric = config.get("FABRIC_NAME", None)
                 child_fabric = config.get("CHILD_FABRIC_NAME", None)
                 try:
-                    self.conversion.validate_fabric_name(parent_fabric)
+                    self.conversion.validate_fabric_name(msd_fabric)
                     self.conversion.validate_fabric_name(child_fabric)
                 except (TypeError, ValueError) as error:
                     msg = f"{self.class_name}: "
@@ -241,7 +241,7 @@ def get_want(self):
                     raise ValueError(msg) from error
             except ValueError as error:
                 raise ValueError(f"{error}") from error
-            config_payload = {'destFabric': parent_fabric, 'sourceFabric': child_fabric}
+            config_payload = {'destFabric': msd_fabric, 'sourceFabric': child_fabric}
             self.payloads.append(copy.deepcopy(config_payload))
 
     def populate_check_mode(self):
@@ -396,8 +396,8 @@ def commit(self) -> None:
                 continue
             self.data[fabric_name] = item
 
-        self.verify_parent_fab_exists_in_controller()
-        self.verify_parent_fab_is_MSD()
+        self.verify_msd_fab_exists_in_controller()
+        self.verify_msd_fab_type()
         for item in self.payloads:
             if not self.verify_child_fabric_is_already_member(item):
                 self.results.action = self.action
@@ -488,8 +488,8 @@ def commit(self) -> None:
                 continue
             self.data[fabric_name] = item
 
-        self.verify_parent_fab_exists_in_controller()
-        self.verify_parent_fab_is_MSD()
+        self.verify_msd_fab_exists_in_controller()
+        self.verify_msd_fab_type()
         self.verify_child_fab_exists_in_controller()
         self.verify_child_fabric_is_member_of_another_fabric()
         for item in self.payloads: