Skip to content

fix: regex pattern matching #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: regex pattern matching #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e56e7
ignore regex by [[ =~ ]]
kounoike Nov 9, 2023
3927fe6
document update
kounoike Nov 9, 2023
cd7d163
\\ -> \
kounoike Nov 9, 2023
6424fc2
Merge branch 'main' into ignore-regex
kounoike Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ jobs:
- `files_to_ignore`: Whitespace or newline separated list of files to ignore when calculating the PR size, regex match is supported.
### files_to_ignore Example:
```yml
files_to_ignore: 'package-lock.json *.lock'
files_to_ignore: 'package-lock\.json .*\.lock'
# OR
files_to_ignore: |
"package-lock.json"
"*.lock"
"docs/*"
"package-lock\.json"
".*\.lock"
"docs/.*"
```
## 🤔 Basic concepts or assumptions

Expand Down
2 changes: 1 addition & 1 deletion src/github.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ github::calculate_total_modifications() {
if [ -z "$file_to_ignore" ]; then
continue
fi
if [[ "$(jq::base64 '.filename')" == $file_to_ignore ]]; then
if [[ "$(jq::base64 '.filename')" =~ $file_to_ignore ]]; then
ignore_file=1
fi
done
Expand Down