Skip to content

Private/gokay/view coordinates #13280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gokaysatir merged 17 commits into from
Nov 17, 2025
Merged

Private/gokay/view coordinates #13280

gokaysatir merged 17 commits into from
Nov 17, 2025

Conversation

@gokaysatir
Copy link
Contributor

@gokaysatir gokaysatir commented Oct 24, 2025

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@gokaysatir
Copy link
Contributor Author

gokaysatir commented Oct 24, 2025

Requires:

@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch 3 times, most recently from 007a07b to 85537ed Compare October 30, 2025 13:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2025
View reviewed changes
@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch 4 times, most recently from 90abc3f to f1f95ac Compare November 5, 2025 10:16
@gokaysatir gokaysatir removed the request for review from Minion3665 November 5, 2025 10:17
@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch 2 times, most recently from d85fd85 to d45b850 Compare November 11, 2025 13:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 11, 2025
View reviewed changes
@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch 3 times, most recently from 7e5dac6 to 87b2d65 Compare November 13, 2025 16:11
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
eszkadev
eszkadev reviewed Nov 14, 2025
View reviewed changes
@gokaysatir
Add view coordinates to SimplePoint and SimpleRectangle classes.
e893177 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Iefad9360f0fb3f0ef31b0a2c99872f2384242845
@gokaysatir
Use simplePoint for paintSimple function. So we can naturally use vX …
cbc1384 
…etc. coordinates.

Multipage view will not need to add functions to tilesSection this way.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Iffc094ebe6443f408658eb37e8598c60b3f69082
@gokaysatir
Writer: Add switch for multipage view / normal view.
6b427be 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I9ff2a2c863c357df7ee6bc57871cf7fe8f8a1bb2
@gokaysatir
Remove "multiPageView" docState (app) variable.
d2e7575 
Views should work without advertising themselves. When there is a need to check, one can use "app.activeDocument.activeView.type".
Also removed "drawPageBackgroundsMultiPageView" function. Hopefully things will work without specialized drawing background functions.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I8334abc4b043b1893141c229c45060b91865464c
@gokaysatir
Rename "MultiPageViewLayout" to "ViewLayoutMultiPage" for consistency.
98ce3a7 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Ic4c70f0f213da6ad2bcea9660384edee5a537912
@gokaysatir
Replace "app.activeDocument.activeView" with this.
e5678c9 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I794216965443ac90cf3ad552c5070c375c180a64
@gokaysatir
Add part variable to SimplePoint and SimpleRectangle classes.
474283c 
New layouts may render different parts at the same time in different coordinates.
Parts may have their own (0, 0) point or they may have a location in a shared space.
Both cases require to know the part numbers of the tiles.
Or we will need draw functions for every layout type.
This property will allow layouts to determine the vX and vY coordinates of points more precisely.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I0b5edd88f01216c9ffdc60c81c4276875600692f
@gokaysatir
Add viewX, viewY properties to ViewLayout->ScrollProperties.
caf54b4 
Don't automatically set the view size in MultiPageView mode.
Don't automatically set the viewed rectangle in MultiPageView mode.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Ifb89f285e13b88beed61009fa8b08c8c7580534d
@gokaysatir
Views should know which coordinates they cover and if the tiles are r…
dbc14ad 
…eady or not.

Added that properties.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I9c5ed3be2defa4d218d08c84cfe41819083794e1
@gokaysatir
Move MyTopLeft calculation into a separate function.
29f4cd8 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I7c0c661f99bdbe25087bcba4091f22bff4745cb5
@gokaysatir
Remove unused function.
f9b3402 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I6932d964aa13577f2a6c5fad7b7f1532b724cc8d
@gokaysatir
Add documentPosition (SimplePoint) property to CanvasSectionObject.
0234f78 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I250dedfcf65c02929d0e02294105d7ab42bcf5c4
@gokaysatir
Use vX and vY coordinates (view coordinates) for document object sect…
d9eb97b 
…ions' myTopLeft properties.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Iec45b6c58cc301b58a77c66ce0b946c4361869c8
@gokaysatir
Isolate multipage view tile-drawing and tile checks from other views.
0ad2f4d 
Adjust multipage view functionalities.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I2af421889f2448f1c09129cbc78ea37dc6cf391f
@gokaysatir
Non-function changes - result of "gmake prettier" command.
cbcf459 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: Ie2734660c0c54e9628883cdb7b0857e1c00446c2
@gokaysatir
Disable the view for now.
1db52fc 
Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I2303b452dd94e8e72fcbd655a17fa66b525452a5
@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch from 7e05c81 to 6d8d93e Compare November 16, 2025 08:32
@gokaysatir
Multipage view layout misc.
07fba48 
* Rename twopages.svg to lc_multipageview.svg so the file is automatically recognized by the JSDialog class.
* Use map state handlers for toggling the multipage view layout. JSDialog class can toggle its button automatically.
* Remove twopages_a.svg since JSDialogs has its own toggled state style.
* Rename getPos2 to getPosSimplePoint and add an explanation.
* Disable setting the viewSize and viewedRectangle properties externally in multipage view. Remove type checks from a few places.

Signed-off-by: Gökay Şatır <[email protected]>
Change-Id: I84634917f221a7908ad14d5ed0f619f61729900d
@gokaysatir gokaysatir force-pushed the private/gokay/view-coordinates branch from 6d8d93e to 07fba48 Compare November 16, 2025 10:58
@gokaysatir gokaysatir requested a review from eszkadev November 16, 2025 12:29
eszkadev
eszkadev reviewed Nov 17, 2025
View reviewed changes
browser/src/control/Control.StatusBar.js
{type: 'toolitem', id: 'signstatus', command: '.uno:Signature', w2icon: '', text: _UNO('.uno:Signature'), visible: false},
{type: 'spacer', id: 'permissionspacer'},
this._generateHtmlItem('documentstatus', 2), // spreadsheet, text, presentation, drawing
{type: 'customtoolitem', id: 'multi-page-view', command: 'multipageview', text: _('Multi Page View'), dataPriority: 10, visible: false}, // text
Copy link
Contributor

@eszkadev eszkadev Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow it is hidden in my case and I cannot get it back, possibly due to dataPriority: ?
I see status-hidden which is done by

online/browser/src/control/jsdialog/Util.ScrollableBar.ts

Line 129 in 96804eb

statusBarItems.forEach((item) => {

yes, I did remove the patch hiding it explicitly :)

eszkadev
eszkadev approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious problems for regular mode.

@github-project-automation github-project-automation bot moved this from To Review to To Test in Collabora Online Nov 17, 2025
@gokaysatir
Copy link
Contributor Author

gokaysatir commented Nov 17, 2025

I don't see any obvious problems for regular mode.

@eszkadev thanks for checking :)

@gokaysatir gokaysatir merged commit e9705ed into master Nov 17, 2025
14 checks passed
@gokaysatir gokaysatir deleted the private/gokay/view-coordinates branch November 17, 2025 10:18
@github-project-automation github-project-automation bot moved this from To Test to Done in Collabora Online Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eszkadev eszkadev eszkadev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Collabora Online
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gokaysatir @eszkadev