Notebookbar: Fix toolbar alignments on safari #13360
Conversation
banobepascal
force-pushed
the
private/banobepascal/notebookbar-alginments-safari
branch
from
56310b3 to
07b143b
Compare
There was a problem hiding this comment.
Please split changes into different commits, 1 for revert and 2nd for the new changes. Also please explain why we are reverting and also why the new changes are needed.
WRT this specific PR and the problem with the vertical alignments in Safari: If adjusting the height solves it for Safari then it seems to me that one or more elements are inheriting different css properties (such as box-sizing, border, line-height and possible some of the flex properties)
Also it would be good to avoid px otherwise the elements do not get scaled up/down depending on the user's zoom
github-project-automation
bot
moved this from To Review
to In Progress
in Collabora Online
banobepascal
force-pushed
the
private/banobepascal/notebookbar-alginments-safari
branch
2 times, most recently
from
cdc69b2 to
b481d49
Compare
-Unotoolbuttons with labels had varying heights across browsers, leading to misaligned toolbar elements. This change enforces a consistent height using `--notebookbar-element-height` and centers their content, ensuring uniform alignment in both Chrome and Safari. Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Ibf2e25eefcc23f12bf52d5eb396837f6affbb15b
banobepascal
force-pushed
the
private/banobepascal/notebookbar-alginments-safari
branch
from
b481d49 to
4f1775d
Compare
pedropintosilva
left a comment
pedropintosilva
left a comment
There was a problem hiding this comment.
I have tested this and it seems ok:
| With this commit |
|---|
 |
 |
| Without this commit |
|---|
 |
I have also checked .unoBezier_Unfilled and yes it seems you are correct , it's not in use
github-project-automation
bot
moved this from In Progress
to To Test
in Collabora Online
|
@banobepascal can you pasted ipad screenshots or did you test on ipad? |
|
I think this might affect negatively ipad: |
WITH THIS COMMIT ON IPAD 
|
|
my screenshot is from iOS 26 yours is from iOS 18, could you please re-test it with iOS 18? |
|
When you are fully happy with this PR, and merge it to master, please backport to distro/collabora/co-25.04 as well. |
IPAD PRo WITH IOS 26 BRANDED IPAD PRo WITH IOS 26 UNBRANDED |
pedropintosilva
deleted the
private/banobepascal/notebookbar-alginments-safari
branch
3 participants
Change-Id: I7059c81ff35b975176b0ee65af7e0293b4973810
Summary
--notebookbar-element-heightand centers their content, ensuring uniform alignment in both Chrome and Safari.PREVIEWS
SAFARI
CHROME
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay