Do not expose internal IDs in public API

Part of #3024

Author: nickygerritsen

webapp/src/Entity/Clarification.php

@@ -40,8 +40,7 @@ class Clarification extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Clarification ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('clarid')]
-    #[Serializer\Groups([ARC::GROUP_RESTRICTED_NONSTRICT])]
+    #[Serializer\Exclude]
     protected int $clarid;
 
     #[ORM\Column(

webapp/src/Entity/Contest.php

@@ -57,7 +57,7 @@ class Contest extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Contest ID', 'unsigned' => true])]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     protected ?int $cid = null;
 
     #[ORM\Column(

webapp/src/Entity/ContestProblem.php

@@ -27,11 +27,6 @@
 #[ORM\Index(columns: ['cid'], name: 'cid')]
 #[ORM\Index(columns: ['probid'], name: 'probid')]
 #[ORM\UniqueConstraint(name: 'shortname', columns: ['cid', 'shortname'], options: ['lengths' => [null, 190]])]
-#[Serializer\VirtualProperty(
-    name: 'probid',
-    exp: 'object.getProblem().getProbid()',
-    options: [new Serializer\Groups([ARC::GROUP_NONSTRICT])]
-)]
 
 #[Serializer\VirtualProperty(
     name: 'short_name',

webapp/src/Entity/Submission.php

@@ -45,8 +45,7 @@ class Submission extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Submission ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('submitid')]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     protected int $submitid;
 
     #[ORM\Column(

webapp/src/Entity/Team.php

@@ -39,8 +39,7 @@ class Team extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Team ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('teamid')]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     protected ?int $teamid = null;
 
     #[ORM\Column(

webapp/src/Entity/TeamAffiliation.php

@@ -43,8 +43,7 @@ class TeamAffiliation extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Team affiliation ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('affilid')]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     protected ?int $affilid = null;
 
     #[ORM\Column(

webapp/src/Entity/TeamCategory.php

@@ -38,8 +38,7 @@ class TeamCategory extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'Team category ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('categoryid')]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     protected ?int $categoryid = null;
 
     #[ORM\Column(

webapp/src/Entity/User.php

@@ -39,8 +39,7 @@ class User extends BaseApiEntity implements
     #[ORM\Id]
     #[ORM\GeneratedValue]
     #[ORM\Column(options: ['comment' => 'User ID', 'unsigned' => true])]
-    #[Serializer\SerializedName('userid')]
-    #[Serializer\Groups([ARC::GROUP_NONSTRICT])]
+    #[Serializer\Exclude]
     private ?int $userid = null;
 
     #[ORM\Column(