You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 27, 2021. It is now read-only.
From libnitrohack/src/pline.c line 29 (emphasis mine):
staticvoidvpline(constchar*line, va_listthe_args)
{
charpbuf[BUFSZ];
if (!line|| !*line) return;
if (strchr(line, '%')) {
vsprintf(pbuf,line,the_args);
line=pbuf;
}
if (no_repeat&& !strcmp(line, toplines[curline])) /* <<< 1 */return;
if (vision_full_recalc)
vision_recalc(0);
if (u.ux)
flush_screen();
strcpy(toplines[curline++], line); /* <<< 2 */curline %= MSGCOUNT;
print_message(moves, line);
}
The line marked 2 always sets curline to the next position in toplines[] to be used, which makes the check at the line marked 1 incorrectly do a string comparison one ahead of the line it should check. This causes Norep() to fail to detect repeated lines when it should.