Skip to content

Conversation

@rahulkaukuntla
Copy link
Contributor

@rahulkaukuntla rahulkaukuntla commented Nov 11, 2025

What does this PR do?

Refer to this
doc
. After talking to stakeholders, we have chosen to implement option 3; the work for this option on the agent side is to fetch the instance type from various cloud providers and report them in a new field in the inventoryhost payload. This branch contains the agent-side work needed to accomplish this.

Motivation

Describe how you validated your changes

We ran an agent on each cloud provider with these changes incorporated, and when we run agent diagnose show-metadata inventory-host, we see instance-type as a field in the payload.

Additional Notes

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

…t to the inventoryhost payload (#42701)

### What does this PR do?

Refer to [this
doc](https://docs.google.com/document/d/1lQiJII2b4R8TzvPElg9Q8ynMqdMg3GHapQ_rVQFmFAQ/edit?usp=sharing).
After talking to stakeholders, we have chosen to implement **option 3**;
the work for this option on the agent side is to fetch the instance type
from various cloud providers and report them in a new field in the
inventoryhost payload. This PR creates the scaffolding for the new
field, and does fetching for ec2 instances.

### Motivation

### Describe how you validated your changes

I ran an agent on ec2 with these changes incorporated, and when I run
`agent diagnose show-metadata inventory-host`, I see `instance-type` as
a field in the payload.

### Additional Notes
@github-actions github-actions bot added medium review PR review might take time team/agent-runtimes labels Nov 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 11, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 93af4b3

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${684.41}$$ < $${695.26}$$ $${+0.01}$$ $${166.79}$$ < $${171.42}$$
agent_deb_amd64_fips $${+0.01}$$ $${678.76}$$ < $${689.56}$$ $${+0.02}$$ $${165.35}$$ < $${168.75}$$
agent_heroku_amd64 $${+0}$$ $${337.07}$$ < $${337.56}$$ $${+0}$$ $${89.77}$$ < $${90.78}$$
agent_msi $${+0.03}$$ $${998.69}$$ < $${1015.38}$$ $${+0}$$ $${144.28}$$ < $${149.42}$$
agent_rpm_amd64 $${+0}$$ $${684.4}$$ < $${695.24}$$ $${+0.04}$$ $${170.0}$$ < $${172.66}$$
agent_rpm_amd64_fips $${+0.01}$$ $${678.75}$$ < $${689.55}$$ $${-0.01}$$ $${167.61}$$ < $${171.31}$$
agent_rpm_arm64 $${+0.01}$$ $${673.93}$$ < $${684.17}$$ $${-0.05}$$ $${154.81}$$ < $${158.47}$$
agent_rpm_arm64_fips $${+0.01}$$ $${669.36}$$ < $${679.54}$$ $${+0.03}$$ $${153.58}$$ < $${156.53}$$
agent_suse_amd64 $${+0}$$ $${684.4}$$ < $${695.24}$$ $${+0.04}$$ $${170.0}$$ < $${172.66}$$
agent_suse_amd64_fips $${+0.01}$$ $${678.75}$$ < $${689.55}$$ $${-0.01}$$ $${167.61}$$ < $${171.31}$$
agent_suse_arm64 $${+0.01}$$ $${673.93}$$ < $${684.17}$$ $${-0.05}$$ $${154.81}$$ < $${158.47}$$
agent_suse_arm64_fips $${+0.01}$$ $${669.36}$$ < $${679.54}$$ $${+0.03}$$ $${153.58}$$ < $${156.53}$$
docker_agent_amd64 $${+0}$$ $${747.49}$$ < $${747.75}$$ $${+0.01}$$ $${251.93}$$ < $${252.67}$$
docker_agent_arm64 $${+0.01}$$ $${761.34}$$ < $${761.44}$$ $${-0.01}$$ $${242.39}$$ < $${243.19}$$
docker_agent_jmx_amd64 $${+0}$$ $${938.37}$$ < $${938.63}$$ $${-0}$$ $${320.56}$$ < $${321.29}$$
docker_agent_jmx_arm64 $${+0.01}$$ $${940.81}$$ < $${940.91}$$ $${-0.01}$$ $${307.0}$$ < $${307.81}$$
docker_cluster_agent_amd64 $${+0.01}$$ $${206.62}$$ < $${207.49}$$ $${+0.01}$$ $${69.29}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0}$$ $${222.49}$$ < $${223.38}$$ $${+0.01}$$ $${65.5}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0.01}$$ $${38.54}$$ < $${39.3}$$ $${+0}$$ $${14.88}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.19}$$ < $${37.94}$$ $${+0}$$ $${14.32}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.84}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0.01}$$ $${28.28}$$ < $${29.11}$$ $${+0}$$ $${6.78}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.85}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.85}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0.01}$$ $${42.31}$$ < $${43.19}$$ $${+0}$$ $${11.05}$$ < $${11.98}$$
iot_agent_deb_arm64 $${+0.01}$$ $${40.04}$$ < $${40.92}$$ $${+0}$$ $${9.52}$$ < $${10.45}$$
iot_agent_deb_armhf $${+0}$$ $${39.98}$$ < $${40.86}$$ $${+0}$$ $${9.62}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${+0.01}$$ $${42.31}$$ < $${43.19}$$ $${+0}$$ $${11.07}$$ < $${12.0}$$
iot_agent_suse_amd64 $${+0.01}$$ $${42.31}$$ < $${43.19}$$ $${+0}$$ $${11.07}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6fd9b0fa-8895-44c3-9c41-0b1a872c5da8

Baseline: 93af4b3
Comparison: 48998c9
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.16 [-0.02, +0.34] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.55 [+1.33, +1.78] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.63 [+0.34, +0.92] 1 Logs
ddot_metrics_sum_delta memory utilization +0.21 [-0.00, +0.43] 1 Logs
docker_containers_cpu % cpu utilization +0.16 [-0.02, +0.34] 1 Logs
file_tree memory utilization +0.06 [+0.01, +0.11] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.03 [-0.04, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.60, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.60, +0.59] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.26, +0.25] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.24, +0.21] 1 Logs
otlp_ingest_logs memory utilization -0.02 [-0.12, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.62, +0.59] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.62, +0.58] 1 Logs
ddot_metrics memory utilization -0.27 [-0.50, -0.04] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.34 [-0.38, -0.29] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.44 [-0.68, -0.21] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.45 [-0.61, -0.29] 1 Logs
otlp_ingest_metrics memory utilization -0.51 [-0.66, -0.37] 1 Logs
quality_gate_idle_all_features memory utilization -0.52 [-0.56, -0.48] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.56 [-0.61, -0.50] 1 Logs
quality_gate_idle memory utilization -0.64 [-0.68, -0.60] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.54 [-4.30, +1.22] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

s-alad and others added 2 commits November 11, 2025 20:29
… payload (#42921)

### What does this PR do?
This branch is forked off #42701 and adds Oracle support for instance-type collection.
### Motivation

### Describe how you validated your changes
```
$ curl -qs -H "authorization: Bearer $(cat ~/datadog-agent/dev/dist/auth_token)" -k https://localhost:5001/agent/metadata/inventory-host | grep "instance-type"

"instance-type": "VM.Standard.E5.Flex",
```
### Additional Notes


Co-authored-by: saad.naji <[email protected]>
…yload (#42764)

### What does this PR do?
This branch is forked off #42701 and adds GCE support for instance-type collection. 

### Motivation

### Describe how you validated your changes

### Additional Notes


Co-authored-by: saad.naji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium review PR review might take time team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants