Make AddServerHooks private

Author: jboolean

contrib/mark3labs/mcp-go/mcpgo.go

@@ -31,12 +31,12 @@ type textIOAnnotator interface {
 	AnnotateTextIO(input, output string, opts ...llmobs.AnnotateOption)
 }
 
-// AddServerHooks appends Datadog tracing hooks to an existing server.Hooks object.
-func AddServerHooks(hooks *server.Hooks) {
-	ddHooks := newHooks()
-	hooks.AddBeforeInitialize(ddHooks.onBeforeInitialize)
-	hooks.AddAfterInitialize(ddHooks.onAfterInitialize)
-	hooks.AddOnError(ddHooks.onError)
+// appendTracingHooks appends Datadog tracing hooks to an existing server.Hooks object.
+func appendTracingHooks(hooks *server.Hooks) {
+	tracingHooks := newHooks()
+	hooks.AddBeforeInitialize(tracingHooks.onBeforeInitialize)
+	hooks.AddAfterInitialize(tracingHooks.onAfterInitialize)
+	hooks.AddOnError(tracingHooks.onError)
 }
 
 func NewToolHandlerMiddleware() server.ToolHandlerMiddleware {

contrib/mark3labs/mcp-go/mcpgo_test.go

@@ -34,7 +34,7 @@ func TestAddServerHooks(t *testing.T) {
 	defer mt.Stop()
 
 	serverHooks := &server.Hooks{}
-	AddServerHooks(serverHooks)
+	appendTracingHooks(serverHooks)
 
 	assert.Len(t, serverHooks.OnBeforeInitialize, 1)
 	assert.Len(t, serverHooks.OnAfterInitialize, 1)
@@ -46,7 +46,7 @@ func TestIntegrationSessionInitialize(t *testing.T) {
 	defer tt.Stop()
 
 	srv := server.NewMCPServer("test-server", "1.0.0",
-		WithTracing(&TracingConfig{}))
+		WithTracing(nil))
 
 	ctx := context.Background()
 	initRequest := `{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"test-client","version":"1.0.0"}}}`
@@ -99,7 +99,7 @@ func TestIntegrationToolCallSuccess(t *testing.T) {
 	defer tt.Stop()
 
 	srv := server.NewMCPServer("test-server", "1.0.0",
-		WithTracing(&TracingConfig{}))
+		WithTracing(nil))
 
 	calcTool := mcp.NewTool("calculator",
 		mcp.WithDescription("A simple calculator"))

contrib/mark3labs/mcp-go/option.go

@@ -30,7 +30,7 @@ func WithTracing(options *TracingConfig) server.ServerOption {
 		if hooks == nil {
 			hooks = &server.Hooks{}
 		}
-		AddServerHooks(hooks)
+		appendTracingHooks(hooks)
 
 		server.WithHooks(hooks)(s)