-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(json-specs): add secret flags on all secret fields #21975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
Looks good. Can you add a changelog for datadog_checks_dev? |
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- datadog_checks_dev/changelog.d/21975.fixed
What does this PR do?
Add
secretflag on all the sensitive fields so that they can be treated as secrets by Fleet Automation.Motivation
https://datadoghq.atlassian.net/browse/FA-1028
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged