Skip to content

Conversation

@Yqnn
Copy link
Contributor

@Yqnn Yqnn commented Nov 26, 2025

What does this PR do?

Add secret flag on all the sensitive fields so that they can be treated as secrets by Fleet Automation.

Motivation

https://datadoghq.atlassian.net/browse/FA-1028

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (f2c29c5) to head (d936e7f).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

steveny91
steveny91 previously approved these changes Nov 26, 2025
@steveny91
Copy link
Contributor

Looks good. Can you add a changelog for datadog_checks_dev?

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review November 28, 2025 10:04

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • datadog_checks_dev/changelog.d/21975.fixed
@Yqnn Yqnn requested a review from steveny91 November 28, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment