Skip to content

Conversation

@ZetaTam-dl
Copy link
Contributor

@ZetaTam-dl ZetaTam-dl commented Oct 20, 2025

What was done

  • Relocate e_sswn and e_sswt from e_sbn and e_sbt to e_ssn and e_sst in writing output
  • It should not affect the results (except the output variables in the above).

Evidence of the work done

  • Video/figures
    <add video/figures if applicable>
  • Clear from the issue description
  • Not applicable

Tests

  • Tests updated
    <add testcase numbers if applicable, Issue number>
  • Not applicable

Documentation

  • Documentation updated
    <add description of changes if applicable, Issue number>
  • Not applicable

Issue link

UNST-8758

@ZetaTam-dl ZetaTam-dl requested a review from jreyns October 20, 2025 15:16
Copy link
Contributor

@jreyns jreyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the linked based transports, not the cell centre ones. I also think that we should do this addition subtraction at the site where they are determined, not at write. The reason for this is that eg the transport over cross-sections will be wrong now.

If you want, we can sit and sort this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants