-
-
Notifications
You must be signed in to change notification settings - Fork 206
Adding authors field #1391 #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kavya-danivas
wants to merge
5
commits into
DependencyTrack:master
Choose a base branch
from
kavya-danivas:adding_authors_field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2c91554
Adding authors field
kavya-danivas b361044
Add author button in view details
kavya-danivas c2bfd38
Add author details in view details form
kavya-danivas 9398d88
Merge branch 'DependencyTrack:master' into adding_authors_field
kavya-danivas 2e1443c
Apply suggestions
kavya-danivas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,59 @@ | ||||||
| <!-- ProjectAddAuthorModal.vue --> | ||||||
| <template> | ||||||
| <b-modal id="projectAddAuthorModal" title="Add Author" hide-footer> | ||||||
| <b-form @submit.prevent="handleSubmit"> | ||||||
| <b-form-group label="Name" label-for="nameInput"> | ||||||
| <b-form-input id="nameInput" v-model="name" placeholder="Enter name" /> | ||||||
| </b-form-group> | ||||||
|
|
||||||
| <b-form-group label="Email" label-for="emailInput"> | ||||||
| <b-form-input id="emailInput" v-model="email" type="email" placeholder="Enter email" /> | ||||||
| </b-form-group> | ||||||
|
|
||||||
| <b-form-group label="Phone" label-for="phoneInput"> | ||||||
| <b-form-input id="phoneInput" v-model="phone" type="tel" placeholder="Enter phone number" /> | ||||||
| </b-form-group> | ||||||
|
|
||||||
| <div class="d-flex justify-content-end"> | ||||||
| <b-button variant="secondary" @click="$bvModal.hide('projectAddAuthorModal')"> | ||||||
| Close | ||||||
| </b-button> | ||||||
| <b-button :disabled="!isFormValid" variant="primary" type="submit" class="ml-2"> | ||||||
| Submit | ||||||
| </b-button> | ||||||
| </div> | ||||||
| </b-form> | ||||||
| </b-modal> | ||||||
| </template> | ||||||
|
|
||||||
| <script> | ||||||
| export default { | ||||||
| name: "ProjectAddAuthorModal", | ||||||
| data() { | ||||||
| return { | ||||||
| name: "", | ||||||
| email: "", | ||||||
| phone: "", | ||||||
| }; | ||||||
| }, | ||||||
| computed: { | ||||||
| isFormValid() { | ||||||
| return this.name && this.email && this.phone; | ||||||
|
||||||
| return this.name && this.email && this.phone; | |
| return this.name && this.email; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
cloneDeep()means the modal now receives a direct reference to the project object. Modifications in the modal will mutate the parent's data directly, potentially causing unintended side effects if changes are cancelled. Consider restoring the deep clone or implementing proper change handling.