Skip to content

Convert to npm#66

Merged
peachbits merged 5 commits into
masterfrom
convert-to-npm
Jun 12, 2026
Merged

Convert to npm#66
peachbits merged 5 commits into
masterfrom
convert-to-npm

Conversation

@peachbits

@peachbits peachbits commented May 26, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Note

Low Risk
Build and dependency workflow changes only; no runtime library code in the shown diff.

Overview
Switches the repo and CI from Yarn to npm as the primary package manager.

Travis now runs on Node 18 with npm ci, npm run lint, and npm run prepare instead of Yarn’s frozen install and yarn scripts. .yarnrc is removed (it previously set ignore-scripts true), and .npmrc adds legacy-peer-deps=true to ease installs under npm’s peer dependency resolution.

.gitignore no longer ignores package-lock.json, so the npm lockfile is intended to be versioned alongside the existing npm-oriented package.json scripts.

Reviewed by Cursor Bugbot for commit 603ce6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz

j0ntz commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

CI status: Travis is red, failing at the install step (Bugbot is clean). Verified from the build log: npm ci crashes with Cannot read property 'biggystring' of undefined because .travis.yml runs node_js: "12" (npm 6), which can't parse lockfileVersion: 3.

Same root cause as EdgeApp/react-native-piratechain#21 — bumping .travis.yml to Node 18 fixes it.

@j0ntz

j0ntz commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Applied in 49aff36 — bumped .travis.yml node_js from 12 to 18 so the bundled npm can parse lockfileVersion: 3 and npm ci installs. Flagging rather than resolving since this is a change I made on your branch, not yours — please review.

@j0ntz j0ntz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — Travis is green after the Node 18 bump. Flagging that this one-line CI change was made by me, so it's worth a quick re-review on your end.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Security review completed with one net-new medium-severity finding on the current PR head.

Open in Web View Automation 

Sent by Cursor Security Agent: Security Reviewer

Comment thread .travis.yml
@peachbits peachbits force-pushed the convert-to-npm branch 2 times, most recently from da225d3 to b83ab5f Compare June 11, 2026 06:32
@peachbits peachbits merged commit 0a3e67b into master Jun 12, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants