Skip to content

Commit b6b51ae

Browse files
committed
Fix pyright inclusions/exclusions to make the CI green
It seems the working-directory parameter in the CI config is ignored if pyproject.toml configures pyright, so tweak that instead.
1 parent fc1d0bd commit b6b51ae

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,10 @@ jobs:
2121
pip install -e ".[dev,faiss]"
2222
- name: Run EKFAC tests that work without GPU
2323
run: pytest -sv tests/ekfac_tests
24-
# TODO: run pyright on whole codebase
25-
- name: Type Checking bergson/hessians
24+
- name: Type Checking
2625
uses: jakebailey/pyright-action@v1
2726
with:
2827
version: 1.1.406
29-
working-directory: bergson/hessians
30-
- name: Type Checking tests/ekfac_tests
31-
uses: jakebailey/pyright-action@v1
32-
with:
33-
version: 1.1.406
34-
working-directory: tests/ekfac_tests
3528
- name: build
3629
run: pip wheel --no-deps -w dist .
3730
env:

pyproject.toml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,14 @@ faiss = [
4040
bergson = "bergson.__main__:main"
4141

4242
[tool.pyright]
43-
include = ["bergson*"]
43+
include = ["bergson*", "tests/ekfac_tests"]
44+
## Temporary excludes before we merge ekfac into the main branch
45+
exclude = [
46+
"bergson/attributor.py",
47+
"bergson/collection.py",
48+
"bergson/gradients.py",
49+
"bergson/utils.py",
50+
]
4451
reportPrivateImportUsage = false
4552

4653
[tool.setuptools.packages.find]

0 commit comments

Comments
 (0)