refactor(permissions): adopt canWrite() helper in move-event ability#292
Merged
Conversation
… move-event ability Follow-up to #290 — adopts the shared AbilityPermissions::canWrite() helper introduced by #288/#291. #290 merged before the helper landed, so the move-event ability shipped with a manage_options stub and a TODO referencing #288. This swaps it to the helper to match the rest of the EC-events surface (e.g. EventUpdateAbilities) and removes the stale TODO. No functional change beyond the permission_callback shape. Refs #287, #288, #290.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #290 — adopts the shared
AbilityPermissions::canWrite()helper from #288/#291 (which merged after #290). No functional change beyond thepermission_callbackshape.Also removes the stale
TODO(#288)comment that the original PR left as a marker.Refs #287, #288, #290.