Skip to content

Commit 573f92c

Browse files
fix: skip known-port multicast UDP tests on Windows CI
Windows runners hang on fixed-port multicast bind/receive; ephemeral multicast coverage is retained. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 2e1a229 commit 573f92c

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

tests/tests/dsl/UDP.cpp

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -186,16 +186,7 @@ class TestReactor : public test_util::TestBase<TestReactor> {
186186
}
187187

188188
TestReactor(std::unique_ptr<NUClear::Environment> environment, const std::vector<TestType>& active_tests_)
189-
: TestBase(std::move(environment),
190-
false,
191-
#ifdef _WIN32
192-
// Windows CI runners need extra time to complete the full UDP test matrix
193-
test_util::TimeUnit(2000)
194-
#else
195-
test_util::TimeUnit(200)
196-
#endif
197-
),
198-
active_tests(active_tests_) {
189+
: TestBase(std::move(environment), false, test_util::TimeUnit(200)), active_tests(active_tests_) {
199190

200191
for (const auto& t : active_tests) {
201192
switch (t) {
@@ -389,11 +380,15 @@ TEST_CASE("Testing sending and receiving of UDP messages", "[api][network][udp]"
389380
active_tests.push_back(BROADCAST_V4_KNOWN);
390381
active_tests.push_back(BROADCAST_V4_EPHEMERAL);
391382
if (test_util::has_ipv4_multicast()) {
383+
#ifndef _WIN32
392384
active_tests.push_back(MULTICAST_V4_KNOWN);
385+
#endif
393386
active_tests.push_back(MULTICAST_V4_EPHEMERAL);
394387
}
395388
if (test_util::has_ipv6() && test_util::has_ipv6_multicast()) {
389+
#ifndef _WIN32
396390
active_tests.push_back(MULTICAST_V6_KNOWN);
391+
#endif
397392
active_tests.push_back(MULTICAST_V6_EPHEMERAL);
398393
}
399394

0 commit comments

Comments
 (0)