Commit 9ca39f4
committed
refactor: improve code quality and add packet processing tests
- Convert iovec C-arrays to std::array<iovec, N> (4 sites in NUClearNet.cpp, 1 in header)
- Replace for(;;){break} in read_socket with while loop
- Split process_packet switch/case into if-else chain dispatching to per-type methods:
process_announce_packet, process_leave_packet, process_connect_packet,
process_data_packet, process_ack_packet
- Make per-type methods public for testability
- Add comprehensive behavioral tests (ProcessPacket.cpp) covering:
validate_header edge cases, packet dispatch, connect handshake,
data delivery/rejection/dedup/reassembly, ACK handling, send paths1 parent 89e3c38 commit 9ca39f4
4 files changed
Lines changed: 685 additions & 204 deletions
File tree
- src/nuclearnet
- tests/tests/nuclearnet
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
0 commit comments