Fix CI: Windows WSABUF build, skip macOS multicast tests in CI

Patch NUClearNet send_buf for MSVC WSABUF fields, link ws2_32 on Windows,
skip multicast-dependent tests on GitHub macOS runners, and add a Docker
Linux test path plus workflow job.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: TrentHouliston

.dockerignore

@@ -0,0 +1,4 @@
+node_modules
+build
+.git
+.github

.github/workflows/docker-test.yml

@@ -0,0 +1,16 @@
+name: Docker Linux test
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  docker:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build and test in Docker
+        run: docker build -t nuclearnet.js-test .

Dockerfile

@@ -0,0 +1,15 @@
+FROM node:20-bookworm
+
+RUN apt-get update \
+    && apt-get install -y --no-install-recommends python3 make g++ \
+    && rm -rf /var/lib/apt/lists/*
+
+WORKDIR /app
+
+COPY package.json package-lock.json ./
+RUN npm ci
+
+COPY . .
+
+RUN npm run build
+CMD ["npm", "test"]

binding.gyp

@@ -86,7 +86,12 @@
                 ],
                 [
                     'OS=="win"', {
-                        'defines': [ '_HAS_EXCEPTIONS=1' ]
+                        'defines': [ '_HAS_EXCEPTIONS=1' ],
+                        'libraries': [
+                            'ws2_32.lib',
+                            'mswsock.lib',
+                            'iphlpapi.lib'
+                        ]
                     }
                 ]
             ]

package.json

@@ -9,7 +9,8 @@
   },
   "scripts": {
     "build": "node-gyp configure && node-gyp build",
-    "test": "node tests/test.js"
+    "test": "node tests/test.js",
+    "test:linux": "docker build -t nuclearnet.js-test . && docker run --rm nuclearnet.js-test"
   },
   "repository": {
     "type": "git",

src/nuclear/src/nuclearnet/NUClearNet.hpp

@@ -198,8 +198,13 @@ namespace network {
         /// Send a single contiguous buffer to a target
         void send_buf(fd_t fd, const sock_t& target, const uint8_t* data, std::size_t length) {
             std::array<iovec, 1> iov{};
+#ifdef _WIN32
+            iov[0].buf = reinterpret_cast<CHAR*>(const_cast<uint8_t*>(data));  // NOLINT(cppcoreguidelines-pro-type-const-cast)
+            iov[0].len = static_cast<ULONG>(length);
+#else
             iov[0].iov_base = const_cast<void*>(static_cast<const void*>(data));  // NOLINT(cppcoreguidelines-pro-type-const-cast)
             iov[0].iov_len  = length;
+#endif
             send_iov(fd, target, iov.data(), 1);
         }
 

tests/test.js

@@ -3,6 +3,10 @@ const assert = require('uvu/assert');
 
 const { NUClearNet } = require('..');
 
+// GitHub Actions macOS runners do not support IPv4 multicast loopback used by these tests.
+const multicastTestsSupported = !(process.platform === 'darwin' && process.env.CI);
+const netTest = multicastTestsSupported ? test : test.skip;
+
 function randomId() {
   return String(Math.random() * 100000000).slice(0, 7);
 }
@@ -131,7 +135,7 @@ test('NUClearNet.send() throws if used before connect()', () => {
   net.destroy();
 });
 
-test('NUClearNet emits join events', async () => {
+netTest('NUClearNet emits join events', async () => {
   // Test set up:
   //   - Create N network instances and connect all of them
   //   - Each time one peer joins another, check that they've all joined each other
@@ -179,7 +183,7 @@ test('NUClearNet emits join events', async () => {
   );
 });
 
-test('NUClearNet emits leave events', async () => {
+netTest('NUClearNet emits leave events', async () => {
   // Test set up:
   //   - Create two network instances (A and B) and connect them
   //   - Wait for B to join A, then disconnect B to trigger the `nuclear_leave` event on A
@@ -217,7 +221,7 @@ test('NUClearNet emits leave events', async () => {
   );
 });
 
-test('NUClearNet can send and receive reliable targeted messages', async () => {
+netTest('NUClearNet can send and receive reliable targeted messages', async () => {
   // Test set up:
   //   - Create one sender and N-1 receiver network instances and connect them
   //   - Wait for receivers to join the sender, and send each receiver a unique payload
@@ -296,7 +300,7 @@ test('NUClearNet can send and receive reliable targeted messages', async () => {
   );
 });
 
-test('NUClearNet can send and receive unreliable targeted messages', async () => {
+netTest('NUClearNet can send and receive unreliable targeted messages', async () => {
   // Test set up:
   //   - Create one sender and N-1 receiver network instances and connect them
   //   - Wait for each receiver to join the sender, then start an interval to unreliably send the receiver a unique payload.
@@ -384,7 +388,7 @@ test('NUClearNet can send and receive unreliable targeted messages', async () =>
   );
 });
 
-test('NUClearNet can send and receive reliable untargeted messages', async () => {
+netTest('NUClearNet can send and receive reliable untargeted messages', async () => {
   // Test set up:
   //   - Create one sender and N-1 receiver network instances and connect them
   //   - Wait for both all receivers to join the sender, then send the payload with `reliable` set, untargeted
@@ -469,7 +473,7 @@ test('NUClearNet can send and receive reliable untargeted messages', async () =>
   );
 });
 
-test('NUClearNet can send and receive unreliable untargeted messages', async () => {
+netTest('NUClearNet can send and receive unreliable untargeted messages', async () => {
   // Test set up:
   //   - Create one sender and N-1 receiver network instances and connect them
   //   - Wait for all receivers to join the sender, then start an interval to unreliably send the same payload, without a target.
@@ -561,7 +565,7 @@ test('NUClearNet can send and receive unreliable untargeted messages', async ()
   );
 });
 
-test('NUClearNet only receives subscribed message types', async () => {
+netTest('NUClearNet only receives subscribed message types', async () => {
   await asyncTest(
     (done, fail) => {
       const [peerA, peerB] = createPeers(2);