Skip to content

YAML tests do not handle included dependencies when loading meta-data JSON files #3792

@alecgrieser

Description

@alecgrieser

The meta-data proto definition allows the user to specify not only a protobuf file descriptor, but also a list of descriptors that are dependencies of the file. The RecordMetaData::fromProto method will then handle making sure that all of the dependencies are created, and then using those to initialize the FileDescriptor for the meta-data.

The YAML tests allow us to provide a JSON definition of the meta-data definition, but if the meta-data has some included dependencies, the loader may still attempt to create the file, leading to errors at class loading time. It should notice if the JSON definition already has the needed dependencies and then avoid attempting to fetch the dependencies from the class path in that circumstance.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions