Revert the order of setOption parameters per swifty coding practices

Author: vishesh

Sources/FoundationDB/Client.swift

@@ -77,30 +77,30 @@ public final class FDBClient: Sendable {
     /// Sets a network option with an optional byte array value.
     ///
     /// - Parameters:
-    ///   - option: The network option to set.
     ///   - value: Optional byte array value for the option.
+    ///   - option: The network option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public static func setNetworkOption(_ option: FDB.NetworkOption, value: [UInt8]? = nil) throws {
+    public static func setNetworkOption(to value: [UInt8]? = nil, forOption option: FDB.NetworkOption) throws {
         try FDBNetwork.shared.setNetworkOption(to: value, forOption: option)
     }
 
     /// Sets a network option with a string value.
     ///
     /// - Parameters:
-    ///   - option: The network option to set.
     ///   - value: String value for the option.
+    ///   - option: The network option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public static func setNetworkOption(_ option: FDB.NetworkOption, value: String) throws {
+    public static func setNetworkOption(to value: String, forOption option: FDB.NetworkOption) throws {
         try FDBNetwork.shared.setNetworkOption(to: value, forOption: option)
     }
 
     /// Sets a network option with an integer value.
     ///
     /// - Parameters:
-    ///   - option: The network option to set.
     ///   - value: Integer value for the option.
+    ///   - option: The network option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public static func setNetworkOption(_ option: FDB.NetworkOption, value: Int) throws {
+    public static func setNetworkOption(to value: Int, forOption option: FDB.NetworkOption) throws {
         try FDBNetwork.shared.setNetworkOption(to: value, forOption: option)
     }
 }

Sources/FoundationDB/Database.swift

@@ -70,10 +70,10 @@ public final class FDBDatabase: DatabaseProtocol {
     /// Sets a database option with a byte array value.
     ///
     /// - Parameters:
-    ///   - option: The database option to set.
     ///   - value: The value for the option (optional).
+    ///   - option: The database option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public func setOption(_ option: FDB.DatabaseOption, value: FDB.Value? = nil) throws {
+    public func setOption(to value: FDB.Value? = nil, forOption option: FDB.DatabaseOption) throws {
         let error: Int32
         if let value = value {
             error = value.withUnsafeBytes { bytes in
@@ -96,23 +96,23 @@ public final class FDBDatabase: DatabaseProtocol {
     /// Sets a database option with a string value.
     ///
     /// - Parameters:
-    ///   - option: The database option to set.
     ///   - value: The string value for the option.
+    ///   - option: The database option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public func setOption(_ option: FDB.DatabaseOption, value: String) throws {
-        try setOption(option, value: Array(value.utf8))
+    public func setOption(to value: String, forOption option: FDB.DatabaseOption) throws {
+        try setOption(to: Array(value.utf8), forOption: option)
     }
 
     /// Sets a database option with an integer value.
     ///
     /// - Parameters:
-    ///   - option: The database option to set.
     ///   - value: The integer value for the option.
+    ///   - option: The database option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    public func setOption(_ option: FDB.DatabaseOption, value: Int) throws {
+    public func setOption(to value: Int, forOption option: FDB.DatabaseOption) throws {
         var val = Int64(value).littleEndian
         try withUnsafeBytes(of: &val) { bytes in
-            try setOption(option, value: Array(bytes))
+            try setOption(to: Array(bytes), forOption: option)
         }
     }
 }

Sources/FoundationDB/FoundationdDB.swift

@@ -252,26 +252,26 @@ public protocol TransactionProtocol: Sendable {
     /// Sets a transaction option with an optional value.
     ///
     /// - Parameters:
-    ///   - option: The transaction option to set.
     ///   - value: Optional byte array value for the option.
+    ///   - option: The transaction option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    func setOption(_ option: FDB.TransactionOption, value: FDB.Value?) throws
+    func setOption(to value: FDB.Value?, forOption option: FDB.TransactionOption) throws
 
     /// Sets a transaction option with a string value.
     ///
     /// - Parameters:
-    ///   - option: The transaction option to set.
     ///   - value: String value for the option.
+    ///   - option: The transaction option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    func setOption(_ option: FDB.TransactionOption, value: String) throws
+    func setOption(to value: String, forOption option: FDB.TransactionOption) throws
 
     /// Sets a transaction option with an integer value.
     ///
     /// - Parameters:
-    ///   - option: The transaction option to set.
     ///   - value: Integer value for the option.
+    ///   - option: The transaction option to set.
     /// - Throws: `FDBError` if the option cannot be set.
-    func setOption(_ option: FDB.TransactionOption, value: Int) throws
+    func setOption(to value: Int, forOption option: FDB.TransactionOption) throws
 }
 
 /// Default implementation of transaction retry logic for `DatabaseProtocol`.
@@ -394,17 +394,17 @@ extension TransactionProtocol {
         try await getRange(beginKey: beginKey, endKey: endKey, limit: limit, snapshot: snapshot)
     }
 
- public func setOption(_ option: FDB.TransactionOption) throws {
-        try setOption(option, value: nil)
+ public func setOption(forOption option: FDB.TransactionOption) throws {
+        try setOption(to: nil, forOption: option)
     }
 
- public func setOption(_ option: FDB.TransactionOption, value: String) throws {
+ public func setOption(to value: String, forOption option: FDB.TransactionOption) throws {
         let valueBytes = [UInt8](value.utf8)
-        try setOption(option, value: valueBytes)
+        try setOption(to: valueBytes, forOption: option)
     }
 
- public func setOption(_ option: FDB.TransactionOption, value: Int) throws {
+ public func setOption(to value: Int, forOption option: FDB.TransactionOption) throws {
         let valueBytes = withUnsafeBytes(of: Int64(value)) { [UInt8]($0) }
-        try setOption(option, value: valueBytes)
+        try setOption(to: valueBytes, forOption: option)
     }
 }

Sources/FoundationDB/Transaction.swift

@@ -96,7 +96,7 @@ public final class FDBTransaction: TransactionProtocol, @unchecked Sendable {
         }
     }
 
-    public func setOption(_ option: FDB.TransactionOption, value: FDB.Value?) throws {
+    public func setOption(to value: FDB.Value?, forOption option: FDB.TransactionOption) throws {
         let error: Int32
         if let value = value {
             error = value.withUnsafeBytes { bytes in

Tests/FoundationDBTests/FoundationDBTests.swift

@@ -1264,7 +1264,7 @@ func transactionTimeoutOption() async throws {
     let newTransaction = try database.createTransaction()
 
     // Set a very short timeout (1ms) to test timeout functionality
-    try newTransaction.setTimeout(1)
+    try newTransaction.setOption(to: 1, forOption: .timeout)
 
     // This should timeout very quickly
     do {
@@ -1293,7 +1293,7 @@ func transactionSizeLimitOption() async throws {
     let newTransaction = try database.createTransaction()
 
     // Set a very small size limit (100 bytes)
-    try newTransaction.setOption(.sizeLimit, 100)
+    try newTransaction.setOption(to: 100, forOption: .sizeLimit)
 
     // Try to write more data than the limit allows
     let largeValue = String(repeating: "x", count: 200)
@@ -1314,9 +1314,9 @@ func transactionOptionConvenienceMethods() throws {
     // Note: These tests verify the API exists but don't actually set options
 
     // Test timeout and retry methods
-    // transaction.setTimeout(30000) - would set timeout
-    // transaction.setRetryLimit(10) - would set retry limit
-    // transaction.setMaxRetryDelay(5000) - would set max retry delay
+    // transaction.setOption(to: 30000, forOption: .timeout) - would set timeout
+    // transaction.setOption(to: 10, forOption: .retryLimit) - would set retry limit
+    // transaction.setOption(to: 5000, forOption: .maxRetryDelay) - would set max retry delay
     // transaction.setSizeLimit(1000000) - would set size limit
 
     // Test idempotency methods

Tests/StackTester/Sources/StackTester/StackTester.swift

@@ -507,7 +507,7 @@ class StackMachine {
         case "DISABLE_WRITE_CONFLICT":
             // Not directly available in Swift bindings, could use transaction option
             let transaction = try currentTransaction()
-            try transaction.setOption(.nextWriteNoWriteConflictRange, value: nil)
+            try transaction.setOption(to: nil, forOption: .nextWriteNoWriteConflictRange)
 
         case "TUPLE_PACK":
             let numElements = waitAndPop().item as! Int64