Merge pull request #321 from RichardPiel/master

ADmad · web-flow · commit 437630398ae3 · 2022-08-31T18:21:20.000+05:30
Bugfix : WkhtmlToPdfEngine with window and PHP 8.x
diff --git a/src/Pdf/Engine/WkHtmlToPdfEngine.php b/src/Pdf/Engine/WkHtmlToPdfEngine.php
@@ -150,7 +150,7 @@ protected function _getCommand(): string
         }
         $command .= ' - -';
 
-        if ($this->_windowsEnvironment) {
+        if ($this->_windowsEnvironment && PHP_MAJOR_VERSION < 8) {
             $command = '"' . $command . '"';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ protected function _getCommand(): string`
`150`	`150`	`}`
`151`	`151`	`$command .= ' - -';`
`152`	`152`
`153`		`- if ($this->_windowsEnvironment) {`
	`153`	`+ if ($this->_windowsEnvironment && PHP_MAJOR_VERSION < 8) {`
`154`	`154`	`$command = '"' . $command . '"';`
`155`	`155`	`}`
`156`	`156`