deprecate direct commandline scripts invocation and exclude nonsense ones

Author: tkmikan

CHANGELOG.md

@@ -72,8 +72,10 @@ The table below shows which release corresponds to each branch, and what date th
 ## 4.14.0 (`dev`)
 
 - [#2356][2356] Add local libc database provider for libcdb
+- [#2364][2364] Deprecate direct commandline scripts invocation and exclude nonsense ones
 
 [2356]: https://github.com/Gallopsled/pwntools/pull/2356
+[2364]: https://github.com/Gallopsled/pwntools/pull/2364
 
 ## 4.13.0 (`beta`)
 

pwnlib/commandline/common.py

@@ -30,3 +30,10 @@ def main(file=sys.argv[0]):
     name = os.path.splitext(os.path.basename(file))[0]
     sys.argv.insert(1, name)
     pwnlib.commandline.main.main()
+
+def deprecated_main():
+    file=sys.argv[0]
+    name = os.path.splitext(os.path.basename(file))[0]
+    import warnings
+    warnings.warn("The '%s' command is deprecated and will be removed in a future version. Please use 'pwn %s' instead." % (name, name), DeprecationWarning, stacklevel=2)
+    main(file)

setup.py

@@ -35,10 +35,10 @@
     filename = os.path.basename(filename)
     filename, ext = os.path.splitext(filename)
 
-    if ext != '.py' or '__init__' in filename:
+    if ext != '.py' or filename in ('__init__', 'common', 'main', 'update', 'version'):
         continue
 
-    script = '%s=pwnlib.commandline.common:main' % filename
+    script = '%s=pwnlib.commandline.common:deprecated_main' % filename
     if not flag:
         console_scripts.append(script)
 
@@ -78,6 +78,5 @@
         ] + templates,
     },
     entry_points = {'console_scripts': console_scripts},
-    scripts              = glob.glob("bin/*"),
     **compat
 )