Resolve channel creation limitations and fix DemoApp search issues #1058
Conversation
Generated by 🚫 Danger |
martinmitrevski
left a comment
martinmitrevski
left a comment
There was a problem hiding this comment.
It still doesn't work well:
- when I first open it, it loads forever and then shows an error
- whenever I open the keyboard, it starts loading (although I haven't typed anything)
- the search still fails from time to time
- it's kind of slow - not sure if it's the backend or sth on the mobile side.
| switch pickerTypeState { | ||
| case let .expanded(attachmentPickerType): | ||
| if composerViewModel.channelController.channel?.canUploadFile == true && composerViewModel.isSendMessageEnabled { | ||
| // Allow attachments even when channel is nil (not yet synchronized) |
There was a problem hiding this comment.
how's that situation possible? By the time you open the picker and select the attachment, the channel is synced. Unless you don't have internet, in which case, it should be disabled.
There was a problem hiding this comment.
We do allow to send attachments as a first message on UIKit when selecting users. On SwiftUI this was not possible.
| // Check if channel needs synchronization (new channel, not yet created) | ||
| let needsSync = channelController.channel == nil | ||
|
|
||
| if needsSync { |
There was a problem hiding this comment.
why do we need this? It's general a bad practice to do ifs in the factory methods.
| } | ||
|
|
||
|
|
||
| func makeEmptyMessagesView( |
There was a problem hiding this comment.
why's this needed?
| import StreamChatSwiftUI | ||
| import SwiftUI | ||
|
|
||
| class NewChatComposerViewModel: MessageComposerViewModel { |
There was a problem hiding this comment.
why's this needed? Seems like the AI went crazy in this PR?
martinmitrevski
left a comment
martinmitrevski
left a comment
There was a problem hiding this comment.
a lot of unnecessary stuff here, let's focus on fixing the search
Public Interface🚀 No changes affecting the public interface. |
|
SDK Size
|
StreamChatSwiftUI XCSize
|
🔗 Issue Links
Resolve https://linear.app/stream/issue/IOS-1262
🎯 Goal
📝 Summary
🧪 Manual Testing Notes
personalchannel with multiple usersgroupchannel with multiple users☑️ Contributor Checklist
docs-contentrepo