SQLite deadlock test

Author: Giorgi

DbExceptionClassifier/Common/IDbExceptionClassifier.cs

@@ -9,6 +9,6 @@ public interface IDbExceptionClassifier
         public bool IsNumericOverflowError(DbException exception);
         public bool IsUniqueConstraintError(DbException exception);
         public bool IsMaxLengthExceededError(DbException exception);
-        public bool IsDeadlockError(DbException exception) => false;
+        public bool IsDeadlockError(DbException exception);
     }
 }

DbExceptionClassifier/Sqlite/SqliteExceptionClassifier.cs

@@ -19,4 +19,6 @@ public bool IsUniqueConstraintError(DbException exception) => exception is Sqlit
     };
 
     public bool IsMaxLengthExceededError(DbException exception) => exception is SqliteException { SqliteExtendedErrorCode: SQLITE_TOOBIG };
+
+    public bool IsDeadlockError(DbException exception) => exception is SqliteException { SqliteExtendedErrorCode: SQLITE_LOCKED_SHAREDCACHE};
 }

EntityFramework.Exceptions/Tests/DatabaseTests.cs

@@ -359,9 +359,9 @@ public virtual async Task Deadlock()
         var id1 = p1.Entity.Id;
         var id2 = p2.Entity.Id;
 
-        using var controlContext = new DemoContext(DemoContext.Options);
-        using var transaction1 = await DemoContext.Database.BeginTransactionAsync();
-        using var transaction2 = await controlContext.Database.BeginTransactionAsync();
+        await using var controlContext = new DemoContext(DemoContext.Options);
+        await using var transaction1 = await DemoContext.Database.BeginTransactionAsync();
+        await using var transaction2 = await controlContext.Database.BeginTransactionAsync();
 
         await DemoContext.Products.Where(c => c.Id == id1)
             .ExecuteUpdateAsync(c => c.SetProperty(p => p.Name, "Test11"));

EntityFramework.Exceptions/Tests/SqliteTests.cs

@@ -1,8 +1,10 @@
 using DotNet.Testcontainers.Containers;
+using EntityFramework.Exceptions.Common;
 using EntityFramework.Exceptions.Sqlite;
 using Microsoft.Data.Sqlite;
 using Microsoft.EntityFrameworkCore;
 using SQLitePCL;
+using System.Linq;
 using System.Runtime.InteropServices;
 using System.Threading.Tasks;
 using Xunit;
@@ -53,10 +55,20 @@ public override Task NumericOverflowViolationThrowsNumericOverflowExceptionThrou
             return Task.CompletedTask;
         }
 
-        [Fact(Skip = "Skipping as SQLite no deadlock.")]
-        public override Task Deadlock()
+        [Fact]
+        public override async Task Deadlock()
         {
-            return Task.CompletedTask;
+            var product = new Product { Name = "Test1" };
+            DemoContext.Products.Add(product);
+
+            await DemoContext.SaveChangesAsync();
+
+            await using var controlContext = new DemoContext(DemoContext.Options);
+            await using var transaction1 = await DemoContext.Database.BeginTransactionAsync();
+
+            await Assert.ThrowsAsync<DeadlockException>(() => controlContext.Products
+                .Where(c => c.Id == product.Id)
+                .ExecuteUpdateAsync(c => c.SetProperty(p => p.Name, "Test12")));
         }
     }