Skip to content

Commit cdf9494

Browse files
committed
SQLite no deadlock
1 parent f428eac commit cdf9494

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

DbExceptionClassifier/Sqlite/SqliteExceptionClassifier.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,4 @@ public bool IsUniqueConstraintError(DbException exception) => exception is Sqlit
1919
};
2020

2121
public bool IsMaxLengthExceededError(DbException exception) => exception is SqliteException { SqliteExtendedErrorCode: SQLITE_TOOBIG };
22-
public bool IsDeadlockError(DbException exception)=> exception is SqliteException { SqliteExtendedErrorCode: SQLITE_LOCKED_SHAREDCACHE };
2322
}

EntityFramework.Exceptions/Tests/SqliteTests.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,22 @@ public override Task NumericOverflowViolationThrowsNumericOverflowExceptionThrou
5252
{
5353
return Task.CompletedTask;
5454
}
55+
56+
[Fact(Skip = "Skipping as SQLite no deadlock.")]
57+
public override Task Deadlock()
58+
{
59+
return Task.CompletedTask;
60+
}
5561
}
5662

5763
public class SqliteDemoContextFixture : DemoContextFixture<IContainer>
5864
{
5965
private const string ConnectionString = "DataSource=file::memory:?cache=shared";
6066

61-
protected override DbContextOptionsBuilder<DemoContext> BuildDemoContextOptions(DbContextOptionsBuilder<DemoContext> builder, string connectionString)
67+
protected override DbContextOptionsBuilder<DemoContext> BuildDemoContextOptions(DbContextOptionsBuilder<DemoContext> builder, string connectionString)
6268
=> builder.UseSqlite(ConnectionString).UseExceptionProcessor();
6369

64-
protected override DbContextOptionsBuilder BuildSameNameIndexesContextOptions(DbContextOptionsBuilder builder, string connectionString)
70+
protected override DbContextOptionsBuilder BuildSameNameIndexesContextOptions(DbContextOptionsBuilder builder, string connectionString)
6571
=> builder.UseSqlite(ConnectionString).UseExceptionProcessor();
6672
}
6773
}

0 commit comments

Comments
 (0)