Bug: Uniswap widget shows error when high price-impact

[L03TJ3]

Bug Description
When doing a trade which has a 100% price-impact, the uniswap widget breaks with 'something went wrong'

This is a calculation error (Division by zero):

Steps to Reproduce

1. Go to gooddapp.org
2. go to swap
3. set pair G$ > cUsd
4. fill in amount below <30 G$
5. see result
6. compare with using app.uniswap, which shows output as 0 for cUsd and a price-impact warning of 100%

...

Expected Behavior
High-price impact of 100% should be shown to user and not show confusing error message.

Proposed solution

• uniswap/widgets barely gets updated or pull-requests merged. so the solution should likely be handled by a patch

[decentralauren]

@L03TJ3 add Uniswap ticket link

[supersonicwisd1]

@L03TJ3 can this be assigned to me?

[L03TJ3]

@supersonicwisd1 sure, is assigned now

[sirpy]

@L03TJ3 I believe we already use some uniswap widget patches based on https://github.com/sirpy/widgets
@supersonicwisd1 notice this requires patching the uniswap widget rather then our own code

[supersonicwisd1]

@L03TJ3 I believe we already use some uniswap widget patches based on https://github.com/sirpy/widgets
@supersonicwisd1 notice this requires patching the uniswap widget rather then our own code

Looking at sirpy's repository, I can see that the getPriceImpactWarning function doesn't have defensive checks for extreme price impact (100% or more) that cause division by zero errors. The function is identical to the problematic one.

Does this mean I should:

1. First add the defensive checks to sirpy's repository (https://github.com/sirpy/widgets)
2. Then update the patch in this repo to include those fixes?

Or should I work on both repositories simultaneously?"

[supersonicwisd1]

Created a PR for a possible fix to https://github.com/sirpy/widgets
this -> https://github.com/sirpy/widgets/pull/2/files

[L03TJ3]

@supersonicwisd1 The repository @sirpy shared was for reference of what has happened/changed.
What we need on ProtocolUI side is applying the needed fix to the uniswap/widgets package using yarn patch.
yarn patch @uniswap/widgets@npm:2.59.0

Note: you cannot extend an existing patch, so patching needs to include both the intented fix, plus previous fixes done.

[sirpy]

@L03TJ3 can you provide the full process how to apply the patch starting from a modified sirpy/widgets repo?