-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to Spark 4.0 to prepare RC #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…spark connect, only pyspark-client is enough
Summary of ChangesHello @Deependra-Patel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the project for its "1.0.0-rc" release by performing a significant upgrade to Spark 4.0 and ensuring full compatibility with the Dataproc s8s 3.0 runtime environment. This involves updating the supported Python version to 3.12 across the project, revising numerous dependency versions, and refining the PySpark installation requirements for better user experience and modularity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully upgrades the project to support Spark 4.0 by updating the Python version to 3.12 and refreshing key dependencies for compatibility with the Dataproc s8s 3.0 runtime. A significant and well-executed change is making pyspark an optional dependency, which enhances the library's flexibility. This is cleanly handled with a runtime check in __init__.py that provides clear installation instructions. The changes are consistent across all modified files. My review includes one suggestion for pyproject.toml to improve the clarity of a dependency version specification for better long-term maintainability.
| "pyarrow>=16.1.0, <17.0.0", | ||
| "pyspark>=3.5.3, <4.0.0", | ||
| "pandas>=2.2.2, <3.0.0", | ||
| "pyarrow>=18.1, <20.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For dependency versioning, it's a good practice to be explicit by including the full patch version. While 18.1 is a valid version specifier, using 18.1.0 is clearer and can prevent potential ambiguity with some package management tools. This small change improves the long-term maintainability and readability of the dependency list.
| "pyarrow>=18.1, <20.0.0", | |
| "pyarrow>=18.1.0, <20.0.0", |
Also changed dependencies to be compatible with Dataproc s8s 3.0 runtime