Skip to content

Conversation

@ML-Marco
Copy link

Fixes #4431

@google-cla
Copy link

google-cla bot commented Oct 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello @ML-Marco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Java 25's flexible main method definitions, allowing the MainClassFinder to correctly identify entry points in applications compiled with the latest Java versions. This enhancement ensures compatibility and proper functionality for projects leveraging JEP 512.

Highlights

  • Support for Java 25 Flexible Main Methods: The MainClassFinder has been updated to recognize the new flexible main method signatures introduced in Java 25 (JEP 512), including static/instance methods with or without String[] args parameters, and with public, protected, or package-private access.
  • ASM Dependency Update: The ASM library dependency has been upgraded from version 9.8 to 9.9, which is necessary to correctly parse Java 25 bytecode.
  • Expanded Test Coverage: New unit tests have been added to validate the correct detection of various Java 25 flexible main method patterns and to ensure private main methods are still not recognized.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for flexible main methods as introduced in Java 25 (JEP 512). The changes involve updating the ASM dependency, modifying the main class detection logic to recognize new main method signatures for Java 25+ class files, and adding corresponding unit tests.

My review has identified a bug in the detection logic where synchronized and strictfp main methods would not be correctly identified. I've also suggested refactoring the new tests to reduce code duplication and adding more test cases for completeness. Overall, this is a great feature addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully support Java 25 and its flexible main methods

1 participant