Tapmoc ignores `kotlin.stdlib.default.dependency=false` in a sub-project's gradle.properties

[OliverO2]

When setting kotlin.stdlib.default.dependency=false in a non-root Gradle project, Tapmoc nevertheless adds the stdlib to the project dependencies. This is undesirable when creating a shadow Jar in one sub-project and the stdlib dependency should be disabled just there.

This code honors the root project's gradle.properties only:

tapmoc/tapmoc-gradle-plugin/src/kgp/kotlin/tapmoc/internal/KgpImpl.kt

Lines 104 to 107 in be675d7

	val isStdlibDefaultDependencyEnabled =
	providers.gradleProperty("kotlin.stdlib.default.dependency")
	.map { it.toBooleanStrictOrNull() != false }
	.getOrElse(true)

Replacing it with the following code would make it work for root and non-root gradle.properties:

val isStdlibDefaultDependencyEnabled =
    project.findProperty("kotlin.stdlib.default.dependency")?.toString()?.toBooleanStrictOrNull() != false

[Goooler]

Needs to get props via ExtraPropertiesExtension, this is due to gradle/gradle#29600.

[martinbonnin]

I agree this is problematic but the handling of Gradle properties in subprojects is itself problematic (see https://docs.gradle.org/current/userguide/best_practices_general.html#do_not_use_gradle_properties_in_subprojects and gradle/gradle#29600)

We can revisit once KGP has a proper API for this. For now, my recommentation is to set kotlin.stdlib.default.dependency=false in the root project and add kotlin-stdlib manually where needed (either in the dependencies {} block or through a convention plugin)

[Goooler]

Sounds reasonable!