make sure the rhino test stuff is handled as test stuff

Author: rbri

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>org.htmlunit</groupId>
     <artifactId>htmlunit-core-js</artifactId>
-    <version>4.11.0</version>
+    <version>4.12.0-SNAPSHOT</version>
     <name>HtmlUnit JavaScript Engine</name>
     <organization>
         <name>HtmlUnit</name>
@@ -20,8 +20,13 @@
         <maven.compiler.source>8</maven.compiler.source>
         <maven.compiler.target>8</maven.compiler.target>
 
+        <!-- test dependencies -->
+        <junit.version>5.12.2</junit.version>
+
+        <!-- quality -->
         <dependencycheck.version>10.0.4</dependencycheck.version>
     </properties>
+
     <build>
        <resources>
          <resource>
@@ -35,13 +40,25 @@
                 <version>3.6.0</version>
                 <executions>
                     <execution>
+                        <id>generate-rhino-sources</id>
                         <phase>generate-sources</phase>
                         <goals>
                             <goal>add-source</goal>
                         </goals>
                         <configuration>
                           <sources>
                               <source>src/repackaged-rhino/java</source>
+                          </sources>
+                        </configuration>
+                    </execution>
+                    <execution>
+                        <id>generate-rhino-test-sources</id>
+                        <phase>generate-test-sources</phase>
+                        <goals>
+                            <goal>add-test-source</goal>
+                        </goals>
+                        <configuration>
+                          <sources>
                               <source>src/repackaged-rhino-test/java</source>
                           </sources>
                         </configuration>
@@ -544,14 +561,20 @@
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-engine</artifactId>
-            <version>5.12.0</version>
+            <version>${junit.version}</version>
             <scope>test</scope>
         </dependency>
         <!--JUnit Jupiter Engine to depend on the JUnit4 engine and JUnit 4 API  -->
         <dependency>
             <groupId>org.junit.vintage</groupId>
             <artifactId>junit-vintage-engine</artifactId>
-            <version>5.12.0</version>
+            <version>${junit.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.junit.platform</groupId>
+            <artifactId>junit-platform-launcher</artifactId>
+            <version>1.12.2</version>
             <scope>test</scope>
         </dependency>
     </dependencies>