Skip to content

Commit 79d897a

Browse files
authored
Enable detect secrets in SPS build pipelines (#406)
* Add .secrets.baseline file for secret detection configuration Signed-off-by: Sophie Shen <[email protected]> * Enable secret detection in CI and PR pipelines Signed-off-by: Sophie Shen <[email protected]> * Rename PPC pipeline to PPC64LE for consistency Signed-off-by: Sophie Shen <[email protected]> * Remove unnecessary binfmt installation step in prepare-buildx target Signed-off-by: Sophie Shen <[email protected]> --------- Signed-off-by: Sophie Shen <[email protected]>
1 parent 7830a49 commit 79d897a

File tree

4 files changed

+133
-8
lines changed

4 files changed

+133
-8
lines changed

.pipeline-config-ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ tasks:
1010
- name: checks-setup
1111
when: 'false'
1212
- name: detect-secrets
13-
when: 'false'
13+
when: 'true'
1414
include:
1515
- docker-socket
1616
- name: compliance-checks

.pipeline-config-pr.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ tasks:
1010
- name: checks-setup
1111
when: 'false'
1212
- name: detect-secrets
13-
when: 'false'
13+
when: 'true'
1414
include:
1515
- docker-socket
1616
- name: unit-test
@@ -42,7 +42,7 @@ tasks:
4242
- name: checks-setup
4343
when: 'false'
4444
- name: detect-secrets
45-
when: 'false'
45+
when: 'true'
4646
include:
4747
- docker-socket
4848
- name: unit-test
@@ -74,7 +74,7 @@ tasks:
7474
- name: checks-setup
7575
when: 'false'
7676
- name: detect-secrets
77-
when: 'false'
77+
when: 'true'
7878
include:
7979
- docker-socket
8080
- name: unit-test
@@ -103,7 +103,7 @@ tasks:
103103
- name: compliance-checks
104104
when: 'false'
105105

106-
pr-code-checks-ppc:
106+
pr-code-checks-ppc64le:
107107
from: pr-code-checks
108108
runtimeClassName: x86-xlarge
109109
include:
@@ -180,15 +180,15 @@ tasks:
180180
runtimeClassName: x86-xlarge
181181
runAfter:
182182
- pr-code-checks-amd64
183-
- pr-code-checks-ppc
183+
- pr-code-checks-ppc64le
184184
- pr-code-checks-s390
185185
include:
186186
- dind
187187
steps:
188188
- name: checks-setup
189189
when: 'false'
190190
- name: detect-secrets
191-
when: 'false'
191+
when: 'true'
192192
include:
193193
- docker-socket
194194
- dind

.secrets.baseline

Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,126 @@
1+
{
2+
"exclude": {
3+
"files": "go.sum|go.mod|^.secrets.baseline$",
4+
"lines": null
5+
},
6+
"generated_at": "2025-11-03T14:16:38Z",
7+
"plugins_used": [
8+
{
9+
"name": "AWSKeyDetector"
10+
},
11+
{
12+
"name": "ArtifactoryDetector"
13+
},
14+
{
15+
"name": "AzureStorageKeyDetector"
16+
},
17+
{
18+
"base64_limit": 4.5,
19+
"name": "Base64HighEntropyString"
20+
},
21+
{
22+
"name": "BasicAuthDetector"
23+
},
24+
{
25+
"name": "BoxDetector"
26+
},
27+
{
28+
"name": "CloudantDetector"
29+
},
30+
{
31+
"ghe_instance": "github.ibm.com",
32+
"name": "GheDetector"
33+
},
34+
{
35+
"name": "GitHubTokenDetector"
36+
},
37+
{
38+
"hex_limit": 3,
39+
"name": "HexHighEntropyString"
40+
},
41+
{
42+
"name": "IbmCloudIamDetector"
43+
},
44+
{
45+
"name": "IbmCosHmacDetector"
46+
},
47+
{
48+
"name": "JwtTokenDetector"
49+
},
50+
{
51+
"keyword_exclude": null,
52+
"name": "KeywordDetector"
53+
},
54+
{
55+
"name": "MailchimpDetector"
56+
},
57+
{
58+
"name": "NpmDetector"
59+
},
60+
{
61+
"name": "PrivateKeyDetector"
62+
},
63+
{
64+
"name": "SlackDetector"
65+
},
66+
{
67+
"name": "SoftlayerDetector"
68+
},
69+
{
70+
"name": "SquareOAuthDetector"
71+
},
72+
{
73+
"name": "StripeDetector"
74+
},
75+
{
76+
"name": "TwilioKeyDetector"
77+
}
78+
],
79+
"results": {
80+
"common/Makefile.common.mk": [
81+
{
82+
"hashed_secret": "1c9b29b40c7759ef4666dff4065908278fa4c837",
83+
"is_secret": false,
84+
"is_verified": false,
85+
"line_number": 30,
86+
"type": "Secret Keyword",
87+
"verified_result": null
88+
}
89+
],
90+
"config/manager/manager.yaml": [
91+
{
92+
"hashed_secret": "b9274fd20e965ade322fd1b50fff623eabaa1c3b",
93+
"is_secret": false,
94+
"is_verified": false,
95+
"line_number": 31,
96+
"type": "Hex High Entropy String",
97+
"verified_result": null
98+
}
99+
],
100+
"helm-cluster-scoped/values.yaml": [
101+
{
102+
"hashed_secret": "da5743b16ccee188d5e5c28cea321ce7a041f4cb",
103+
"is_secret": false,
104+
"is_verified": false,
105+
"line_number": 2,
106+
"type": "Secret Keyword",
107+
"verified_result": null
108+
}
109+
],
110+
"helm/values.yaml": [
111+
{
112+
"hashed_secret": "da5743b16ccee188d5e5c28cea321ce7a041f4cb",
113+
"is_secret": false,
114+
"is_verified": false,
115+
"line_number": 5,
116+
"type": "Secret Keyword",
117+
"verified_result": null
118+
}
119+
]
120+
},
121+
"version": "0.13.1+ibm.64.dss",
122+
"word_list": {
123+
"file": null,
124+
"hash": null
125+
}
126+
}

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ e2e-test: ## Run e2e test
229229
prepare-buildx:
230230
@docker buildx inspect $(BUILDX_BUILDER) >/dev/null 2>&1 || docker buildx create --name $(BUILDX_BUILDER) --driver docker-container --use
231231
@docker buildx use $(BUILDX_BUILDER)
232-
@docker run --privileged --rm tonistiigi/binfmt --install all >/dev/null
233232

234233
build-operator-image: config-docker prepare-buildx ## Build the operator image.
235234
@echo "Building the $(OPERATOR_IMAGE_NAME) docker image for $(LOCAL_ARCH)..."

0 commit comments

Comments
 (0)